[#11450] - Admin Modules Cache
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 11450
- Diff
- brianteeman:adminmodule
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11449 .
Summary of Changes
If you check the Advanced options for 90% of the admin modules you will see they have an option for cache that has just one setting - no cache.
That doesnt make any sense to me at all. If you cant change it then it doesnt need to be there.
joomla-cms-bot
- | Category | ⇒ | Administration Modules |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11450.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11450.
| Status | Pending | ⇒ | Ready to Commit |
Thank you for testing RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11450.
| Labels |
Added:
?
|
||
For completeness the cache field is always used (whether configurable or not in https://github.com/joomla/joomla-cms/blob/3.6.2/libraries/joomla/document/renderer/html/module.php#L81) but default value is also 0 as it is in all these admin modules - so indeed it's pointless as long as the single value is 0. If the only selectable value is non-0 then we would need to keep it or make it a hidden field etc.
PR is completely valid and still RTC - just some background
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 17:46:10 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 1ba2a7b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11450.