You'd need to dig into JModuleHelper and make sure whatever uses that parameter doesn't default to on to do it safely I guess.

OK will do - failing that it could just be a hidden field - which seems
perfectly safe then

On 4 August 2016 at 16:26, Michael Babker notifications@github.com wrote:

You'd need to dig into JModuleHelper and make sure whatever uses that
parameter doesn't default to on to do it safely I guess.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11449 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Qag2QyY8ONn3bvMntophPm0qFZGks5qcgSagaJpZM4Jc0F-
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

is this bit of code you are referring to
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/document/renderer/html/module.php#L81

Looks about right.

And again this bit
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/module/helper.php#L474

Which if I am reading it all correctly means I can safely delete the param from the xml and there is no need to worry about existing sites that have it set

Yep, should be no issues.

Thank you

See #11450