? Success

User tests: Successful: Unsuccessful:

avatar demis-palma
demis-palma
29 Jul 2016

JDatabaseQuery::leftJoin() method is camel case.
2 method calls changed accordingly.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2016
Category CLI
avatar demis-palma demis-palma - open - 29 Jul 2016
avatar demis-palma demis-palma - change - 29 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2016
Labels Added: ?
avatar alikon
alikon - comment - 30 Jul 2016

may i suggest you instead to use something like

->join('LEFT', $db->qn('#__finder_taxonomy') . ' AS p ON p.id = t.parent_id')

as is as a standard "de facto" on all core code

avatar n9iels
n9iels - comment - 30 Jul 2016

Why is that the standard? JDatabaseQuery::leftJoin() looks better because it is more abstract and if they both do the same...

avatar wilsonge wilsonge - change - 30 Jul 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-30 13:32:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Jul 2016
avatar wilsonge wilsonge - merge - 30 Jul 2016

Add a Comment

Login with GitHub to post a comment