[#11360] - Fix: Warning: Parameter 1 to JError::customErrorPage() PHP7.0.9
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: 1 PhilETaylor Unsuccessful: 0
On the new PHP 7.0.9 version you will getting some warnings like:
Warning: Parameter 1 to JError::customErrorPage() expected to be a reference, value given in C:\wamp\www\develop\libraries\legacy\error\error.php on line 781
test instructions:
Set environment to PHP 7.0.9
Use a component that using custom error pages like kunena.
Add a extra letter on the url on the category name.
Before fix:
above warning message
After fix:
Showed the custom error page
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
It's still going to have to be addressed. From the looks of that bug
report the change was reverted in PHP 7.0 but will exist in 7.1.
On Friday, July 29, 2016, Jelle Kok notifications@github.com wrote:
On hold, if php is reverting the change.
https://bugs.php.net/bug.php?id=72698
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11360 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoSRXuKnpPSiS4I7jqRL4MEE8Dgilks5qaoydgaJpZM4JYoSg
.
other warning is:
PHP Warning: Parameter 1 to PlgSystemRedirect::handleError() expected to be a reference, value given in /home/user/public_html/libraries/legacy/error/error.php on line 781
but i haven't able this fix this warning
Yes they !might revert it in 7.0.10 but will definitely introduce it n 7.1.0
I have tested this item
Before this PR a random url such as utu9ur0t9 will give the reported error
After this PR it is all good
You dont need kunena to test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11360.
PHP Warning: Parameter 1 to PlgSystemRedirect::handleError() expected to be a reference, value given in /home/user/public_html/libraries/legacy/error/error.php on line 781
maybe remove the & here too?
https://github.com/joomla/joomla-cms/blob/staging/plugins/system/redirect/redirect.php#L65
I have tested this item
Before the patch got a 0 - Call to a member function get() on null error when trying to access a not existing article. After the patch I get a 404 error like expected
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11360.
| Priority | Medium | ⇒ | Urgent |
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries Plugins Front End |
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-30 13:18:58 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item
Tested on PHP 7.0.9
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11360.
It was merged @PhilETaylor
On hold, if php is reverting the change.
https://bugs.php.net/bug.php?id=72698