? Pending

User tests: Successful: Unsuccessful:

avatar 810
810
29 Jul 2016

On the new PHP 7.0.9 version you will getting some warnings like:

Warning: Parameter 1 to JError::customErrorPage() expected to be a reference, value given in C:\wamp\www\develop\libraries\legacy\error\error.php on line 781

test instructions:

Set environment to PHP 7.0.9
Use a component that using custom error pages like kunena.

Add a extra letter on the url on the category name.

Before fix:
above warning message
After fix:
Showed the custom error page

avatar 810 810 - open - 29 Jul 2016
avatar 810 810 - change - 29 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2016
Category Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2016
Labels Added: ?
avatar 810
810 - comment - 29 Jul 2016

On hold, if php is reverting the change.

https://bugs.php.net/bug.php?id=72698

avatar mbabker
mbabker - comment - 30 Jul 2016

It's still going to have to be addressed. From the looks of that bug
report the change was reverted in PHP 7.0 but will exist in 7.1.

On Friday, July 29, 2016, Jelle Kok notifications@github.com wrote:

On hold, if php is reverting the change.

https://bugs.php.net/bug.php?id=72698


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11360 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoSRXuKnpPSiS4I7jqRL4MEE8Dgilks5qaoydgaJpZM4JYoSg
.

avatar 810
810 - comment - 30 Jul 2016

other warning is:

PHP Warning: Parameter 1 to PlgSystemRedirect::handleError() expected to be a reference, value given in /home/user/public_html/libraries/legacy/error/error.php on line 781

but i haven't able this fix this warning

avatar brianteeman
brianteeman - comment - 30 Jul 2016

Yes they !might revert it in 7.0.10 but will definitely introduce it n 7.1.0

avatar brianteeman brianteeman - test_item - 30 Jul 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Jul 2016

I have tested this item successfully on fdbe1ab

Before this PR a random url such as utu9ur0t9 will give the reported error
After this PR it is all good

You dont need kunena to test


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11360.

avatar zero-24
zero-24 - comment - 30 Jul 2016

@810

PHP Warning: Parameter 1 to PlgSystemRedirect::handleError() expected to be a reference, value given in /home/user/public_html/libraries/legacy/error/error.php on line 781

maybe remove the & here too?

https://github.com/joomla/joomla-cms/blob/staging/plugins/system/redirect/redirect.php#L65

avatar n9iels n9iels - test_item - 30 Jul 2016 - Tested successfully
avatar n9iels
n9iels - comment - 30 Jul 2016

I have tested this item successfully on fdbe1ab

Before the patch got a 0 - Call to a member function get() on null error when trying to access a not existing article. After the patch I get a 404 error like expected


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11360.

avatar brianteeman brianteeman - change - 30 Jul 2016
Priority Medium Urgent
avatar brianteeman brianteeman - change - 30 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 30 Jul 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11360.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2016
Category Libraries Libraries Plugins Front End
avatar 810
810 - comment - 30 Jul 2016

@zero-24 yes thats worked, thnx updated this pr, with that fix also

avatar wilsonge wilsonge - change - 30 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-30 13:18:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Jul 2016
avatar wilsonge wilsonge - merge - 30 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 30 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2016
Labels Removed: ?
avatar PhilETaylor PhilETaylor - test_item - 31 Jul 2016 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 31 Jul 2016

I have tested this item successfully on 1cbc40f

Tested on PHP 7.0.9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11360.

avatar brianteeman
brianteeman - comment - 31 Jul 2016

It was merged @PhilETaylor

Add a Comment

Login with GitHub to post a comment