[#11359] - Don't need values for async/defer on HTML5
- Closed
- 13 Aug 2016
- Medium
- Build: staging
- # 11359
- Diff
- mbabker:async-defer
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
In HTML5 we don't need to specify values for the async and defer attributes on script tags. So, save a few characters in the HTML output, don't send them.
Testing Instructions
Pre-patch when adding an async'd script the output should be similar to this:
<script src="/templates/joomla/js/template.js" async="async"></script>Post-patch, it should look like this:
<script src="/templates/joomla/js/template.js" async></script>
I have tested this item
On review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11359.
| Status | New | ⇒ | Ready to Commit |
| Category | ⇒ | Libraries |
No labels...
@joomla-cms-bot please RTC
The bot, like me, is taking today off to drink excessively
On Saturday, July 30, 2016, Luca Marzo notifications@github.com wrote:
No labels...
@joomla-cms-bot https://github.com/joomla-cms-bot please RTC—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11359 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfof6S_VRB69c3B-TMP3LGEP7bb86bks5qa5JNgaJpZM4JYhfS
.
It's saturday, maybe it's on holiday :)
I think there might be a bigger issue. Over the last few days I have
sometimes clicked on a link to an issue in an email and only ended up on
the home page pf the tracker and not the issue and then when I click on the
issue directly I only get the home page
On 30 July 2016 at 19:08, Luca Marzo notifications@github.com wrote:
It's saturday, maybe it's on holiday :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11359 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8c5pcgBZ-nbQNvtjfGS5wZA6h5xlks5qa5MIgaJpZM4JYhfS
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Adding it manually seemed to have worked
You have to explicitly call $doc->setHtml5(true); to cause this change to happen. So if you're using XHTML5, I'd say you wouldn't be calling this so the attributes wouldn't change in that case.
Well, I'm for full HTML attributes, just like closing all HTML tags (which is not required in HTML5).
But I'm aware it's more a personal aesthetics related opinion.
I have tested this item✅ successfully on e0cca7b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11359.