[#11362] - Missing commas
- Fixed in Code Base
- 30 Jul 2016
- Medium
- Build: staging
- # 11362
- Diff
- demis-palma:missing-comma-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: 2 Lavsteph, MATsxm Unsuccessful: 0
The problem regards RTL css. Looking at the corresponding LTR css, it's clear that a few commas went lost.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Templates (admin) Administration |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11362.
At least with Isis there should be a corresponding LESS file (I don't think
I ever got to LESS for RTL in Hathor). Can you make sure there isn't a
LESS file that needs correcting?
On Friday, July 29, 2016, Demis Palma ツ notifications@github.com wrote:
The problem regards RTL css. Looking at the corresponding LTR css, it's
clear that a few commas went lost.
You can view, comment on, or merge this pull request online at:
#11362
Commit Summary
- Fixed commas
File Changes
- M administrator/templates/hathor/css/colour_blue_rtl.css https://github.com/joomla/joomla-cms/pull/11362/files#diff-0 (2)
- M administrator/templates/hathor/css/colour_brown_rtl.css https://github.com/joomla/joomla-cms/pull/11362/files#diff-1 (2)
- M administrator/templates/hathor/css/colour_standard_rtl.css https://github.com/joomla/joomla-cms/pull/11362/files#diff-2 (2)
- M administrator/templates/isis/css/template-rtl.css https://github.com/joomla/joomla-cms/pull/11362/files#diff-3 (2)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/11362.patch
- https://github.com/joomla/joomla-cms/pull/11362.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11362, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoVH_J55N3CaAFQDxhivxre-HuxErks5qapBwgaJpZM4JYqXT
.
I'll take a look and let you know.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11362.
There is no RTL less file for hathor
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-30 14:24:22 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@jeckodevelopment @Lavsteph @MATsxm @brianteeman Please test #11369
I have tested this item✅ successfully on 6c89cea