[#11301] - Fixed method case
- Closed
- 28 Jul 2016
- Medium
- Build: staging
- # 11301
- Diff
- demis-palma:getdbo
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Summary of Changes
The method JFactory::getDBO() has been renamed to JFactory::getDbo() a few time ago.
I've updated 3 method calls.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries External Library Plugins Front End |
| Labels |
Added:
?
|
||
@zero-24 from what I know, fof library has been donated to the Joomla project and its up to Joomla to maintain it.
The original author has discontinued fof and created F0F instead.
I have tested this item
Looks good on code review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11301.
Anyway it is up to the maintainer to decide. If we really want to maintain that lib we have much more todo ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11301.
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11301.
| Status | Pending | ⇒ | Needs Review |
Moiving to Needs review so a maintainer can take that
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11301.
Thanks to both for testing and confirm.
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11301.
We should fix the one in the update notification pluging but not in FOF. As you said, we don't fix stuff in 3rd party libraries.
@jeckodevelopment No we cannot. The procedure is fixed, we don't fix upstream bugs. This should be done by the package maintainer.
Ok! got it, thanks!
brianteeman
- | Milestone |
Removed: |
||
The procedure is fixed, we don't fix upstream bugs.
Except FOF2 is EOL'd and Nic has pretty much explicitly stated if there's something that needs to be fixed in the code shipping with Joomla to do so. The same would have to apply if a bug was found in the phputf8 library; sure it's "upstream" but it's been unsupported for a long time.
@roland-d I'm a bit confused. I see several commits by Joomla members on fof,
- made everytime, from the year 2013 up to a month ago,
- about everything, from "PHP 7 compatibility" to "Grammar and error in comments",
- made by everyone: piotrmocko, wilsonge, brianteeman, okonomiyaki3000, phproberto, dbhurley, Bakual, mbabker and infograf768. Besides, of course nikosdion.
So, do you confirm that I really should revert the proposed fix to the fof file?
The PHP 7 Compatibility was done in conjunction with Nic and actually got changed in the PR to ensure it was exactly the same as the fix made in the official FOF 2 repository. All other commits as far as I can see have been updates to the FOF library... (just some were not done by Nic)
So yes you need to revert this part unless nic chooses to accept it in FOF core
| Category | Libraries External Library Plugins Front End | ⇒ | Plugins Front End |
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11301.
I still don't understand, but I obey.
Changes to the fof reverted as required.
| Status | Needs Review | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-28 14:11:07 |
| Closed_By | ⇒ | wilsonge |
@demis-palma hmm generaly we don't change 3party libs such as fof ;) But it is up to the PLT / Maintaienr to decide :)