[#11300] - Use layouts in the vote plugin
- Closed
- 30 Jul 2016
- Medium
- Build: staging
- # 11300
- Diff
- mbabker:vote-plugin-layouts
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This makes it rather easy to customize the voting plugin's output by moving all the logic for the different parts of it to layouts.
Testing Instructions
Apply patch, ensure plugin still renders correctly. Override one of the new layouts (place at templates/<template>/html/plg_content_vote/<layout>.php) and ensure your override is used.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Plugins Front End |
| Labels |
Added:
?
|
||
I have not tested this item.
I am using 5.3.10 version in my setup to test this patch and getting Parse error: syntax error, unexpected '[' in /var/www/joomla-cms/plugins/content/vote/tmpl/vote.php on line 27
I found that line 27 contains $options = []; and error is because of []. As I see joomla should work in 5.3.10 according to https://www.joomla.org/about-joomla/technical-requirements.html I think my test is unsuccessful.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Labels | |||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-30 13:57:31 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on ffc6845
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11300.