? Success

User tests: Successful: Unsuccessful:

avatar demis-palma
demis-palma
25 Jul 2016

Summary of Changes

There is a call to method Registry::get() with 3 parameters, while it only accepts 2 parameters
(see libraries/vendor/joomla/registry/src/Registry.php)
public function get($path, $default = null)

The code has been clearly copied / pasted from a call to JInput::get(), which actually accepts a third parameter indicating the filter type, and 'int' is a valid value.

If we want to be sure to get an int, the correct way is use a cast as we already did 3 lines below.

avatar demis-palma demis-palma - open - 25 Jul 2016
avatar demis-palma demis-palma - change - 25 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2016
Category Plugins Front End
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 28 Jul 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-28 10:19:19
Closed_By wilsonge
avatar wilsonge wilsonge - close - 28 Jul 2016
avatar wilsonge wilsonge - merge - 28 Jul 2016
avatar wilsonge
wilsonge - comment - 28 Jul 2016

Merged on review

Add a Comment

Login with GitHub to post a comment