[#11246] - ISIS (list views) - Replace html/pagination.php::pagination_list_footer() by JLayouts
- Closed
- 11 Sep 2016
- Medium
- Build: 3.7.x
- # 11246
- Diff
- bertmert:patch-10
User tests: Successful: Unsuccessful:
Summary of Changes
- Replace in ISIS template deprecated override of pagination via html/pagination.php in all backend list views by JLayouts.
- Remove method pagination_list_footer() from ISIS html/pagination.php.
- Create overrides for joomla.pagination.link.php and joomla.pagination.links.php.
- Add features:
- - Current page number also visible on phones.
- - Expand tooltip for End link with information about total pages.
Testing Instructions
- Backend. ISIS template.
- Open administrator/index.php?option=com_content&view=articles or any other list view in backend (core components).
- Set limit box to 5 to make sure that a pagination list is displayed below items list.
- Test pagination also in smaller device widths.
Apply patch.
- Compare pagination behavior.
- Nothing has changed BUT
- - On small devices you'll see the current page number (red arrow).
- - You'll see an additional info on End link about number of total pages (green arrow)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Templates (admin) Libraries |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Category | Administration Components Templates (admin) Libraries | ⇒ | Templates (admin) Administration Libraries |
| Title |
|
||||||
@bertmert One suggestion, Here at the end we can see "End (Page 14 of 14)", so it would be good that we can see "Start (Page 1 of 14)" in tool tip.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11246.
I have tested this item
Great work @bertmert
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11246.
@RonakParmar
Thanks for testing!
One suggestion, Here at the end we can see "End (Page 14 of 14)", so it would be good that we can see "Start (Page 1 of 14)" in tool tip.
Even if I think that it's obvious that Start = Page 1 I changed the code because an information about total pages count could be helpful here, too, sometimes.
Let's keep things exactly the same as they are for this PR ;) Single responsibility - just move to JLayouts :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11246.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Can you fix the conflicts here please
Could somebody please help me.
When a PR has a Milestone 3.7.0 and there is a merge conflict is it against Staging or do I have to solve the conflicts against 3.7.0?
(I solved it against Staging).
Thx!
I changed the branch for this PR, conflicts must be solved for the 3.7.x branch
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-11 18:31:23 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 763b2cb
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11246.