[#11245] - [installation] update user ids even if there is no sample data
- Fixed in Code Base
- 22 Jul 2016
- Medium
- Build: staging
- # 11245
- Diff
- andrepereiradasilva:update-ids
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11228.
Summary of Changes
When you make a new install of Joomla without sample data, i.e., selecting None (Required for basic native multilingual site creation) in the sample data install step, joomla will install the joomla.sql without changing the ids of the created_user_id in the table records.
One example is the #__categories table "Uncategorised" categories. The user id 42 ( https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L241-L247 ) is hardcoded as you can see from next picture.
This is a bug by itself (exists on 3.5.1 too), but in latest staging this leads to a warning when trying to edit those categories because the user id doesn't exist.
This user_id needs to be updated to the random generated super user id.
This PR solves this issue.
Testing Instructions
- Use latest staging and make a new install with
None (Required for basic native multilingual site creation)in the sample data install step - Check the categories table is created with user id 42
- Check when you edit any "Uncategorised" category you have the warning above.
- Now download https://github.com/andrepereiradasilva/joomla-cms/archive/update-ids.zip (staging + this PR)
- Repeat step 1 to 3 check is all ok now.
- Do a code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
?
|
||
I have tested this item
Confirmed issue with userid42 and tested an install with this patch and its all good
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11245.
| Rel_Number | 0 | ⇒ | 112288 |
| Relation Type | ⇒ | Pull Request for |
| Rel_Number | 112288 | ⇒ | 11228 |
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
I have tested this item
Able to reproduce then patch works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11245.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-22 20:39:51 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@andrepereiradasilva
When installing Sample blog, I still have the issue.
JUser: :_load: Unable to load user with ID: 713
i think you have that because of the modified_by, IIRC this PR only corrects the created_by.
we can make a PR to update those too.
That would make sense. If thats the case then the PR doesnt need updating
as we have at least one other PR to address the situation of a deleted user
in the modified field
On 20 November 2016 at 11:14, andrepereiradasilva notifications@github.com
wrote:
i think you have that because of the modified_by, IIRC this PR only
corrects the created_by.
we can make a PR to update those too.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11245 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Xt81ZrnNoiBv7LwcA-i_LQIONWBks5rACuBgaJpZM4JSwbS
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
working on it
I have tested this item✅ successfully on 9c55adc
no more warning, created_user_id now respect the superadmin user id
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11245.