?
Referenced as Pull Request for: # 11245
avatar andrepereiradasilva
andrepereiradasilva
21 Jul 2016

Steps to reproduce the issue

  • Install latest staging with None (Required for basic native multilingual site creation) in the sample data.
  • After install edit any "Uncategorised" category

Expected result

No warning

Actual result

image

System information (as much as possible)

Latest staging

Additional comments

I have no user id 42 on the database.

The user id 42 is harcoded (??) in the install sql (https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L241-L247) but it has been like that for a while, so some new check is being done in latest staging.

avatar andrepereiradasilva andrepereiradasilva - open - 21 Jul 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Jul 2016
The description was changed
avatar brianteeman brianteeman - change - 21 Jul 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 21 Jul 2016
Category Installation
avatar alikon
alikon - comment - 21 Jul 2016

can confirm
something is going wrong with com_categories....

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Jul 2016

ok so it's really a regression

avatar andrepereiradasilva andrepereiradasilva - change - 21 Jul 2016
Title
Regression? Warning on edit "Uncategorized" categories
[REGRESSION] Warning on edit "Uncategorized" categories
avatar andrepereiradasilva andrepereiradasilva - change - 21 Jul 2016
Title
Regression? Warning on edit "Uncategorized" categories
[REGRESSION] Warning on edit "Uncategorized" categories
avatar mbabker
mbabker - comment - 21 Jul 2016

The install app is supposed to reset the user ID on all records in the sample data. That code wasn't changed or skipped in any way, was it?

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Jul 2016

don't know i have the problem in two different test sites.
can you check?

avatar mbabker
mbabker - comment - 21 Jul 2016

I see nothing that's changed InstallationModelDatabase::postInstallSampleData() in some time. Honestly the most notable changes in the install app were JavaScript tweaks and language strings.

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Jul 2016

really don't know. need more people to check if this.

is a simple test. just enter edit mode of any "Uncategorized" category in any component.

avatar infograf768
infograf768 - comment - 22 Jul 2016

I can't reproduce on anew install. My superUser gets id 618

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

Forget my last comment

I can't reproduce on anew install. My superUser gets id 618

The question is not what's the id you get for your super user.
The question is the categories named "Uncategorized" have in the database that they were created with user id 42 and them we get that warning editing them...

Just tested in clean staging without any sample/test data and i get the user id 42 as the user who created those categories and get the warning when trying to edit the category.

IMO this is a regression.

avatar infograf768
infograf768 - comment - 22 Jul 2016

I do not get the warning at all. In database 42 is replaced by 618.
Php 5.4.4

avatar infograf768
infograf768 - comment - 22 Jul 2016

used simple sample data

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

in #__categories table?

just to prove i'm not crazy
image

avatar infograf768
infograf768 - comment - 22 Jul 2016

I used sampledata.sql which does not change anyhting to categories vs joomla.sql
This may be useful to find out where is the culprit.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

i used a clean staging install in a new database with new prefix and did not install any sample data, nor any multilanguage. Just next, next ... next.

avatar infograf768
infograf768 - comment - 22 Jul 2016

I know what you did and I get the same warning in that case.
What I try to say is that IF I install sampledata.sql instead of nothing, and although sampledata.sql does NOT contain any change to com_categories (which therefore means normally that only the joomla.sql records are used for these), then I do not get the issue.

This may be useful to find out where is the culprit.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

You're right, if you select "Default English (GB) Sample Data" it works fine, the id gets updated.

But if you select "None (Required for basic native multilingual site creation)" the id doesn't get updated!

Please confirm you have the same issue.

avatar infograf768
infograf768 - comment - 22 Jul 2016

done above ?

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

so do you agree this is a regression?

avatar andrepereiradasilva andrepereiradasilva - change - 22 Jul 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 22 Jul 2016
The description was changed
avatar infograf768
infograf768 - comment - 22 Jul 2016

Never tested before I must say. It should be solved indeed I guess.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

i don't have this issue in a clean 3.5.1 so it's a regression IMO

actually they are created with id 42 but in 3.5.1 there is no warning.

avatar alikon
alikon - comment - 22 Jul 2016

Yes happens when you do a fresh install with multilingual

On 22 Jul 2016 12:55 pm, "infograf768" notifications@github.com wrote:

Never tested before I must say. It should be solved indeed I guess.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11228 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFsdqWWAX5DlbAkCLAp0chvzc_dgPmks5qYKGTgaJpZM4JRszb
.

avatar andrepereiradasilva andrepereiradasilva - change - 22 Jul 2016
The description was changed
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

yes, basicly all new installs multilanguage (or monolanguage without any sample data) get this issue.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

i think the issue is postInstallSampleData https://github.com/joomla/joomla-cms/blob/staging/installation/model/database.php#L772 is not run if you don't install sample data.

which from logic perspective makes sense (if you don't install sample data why run a method called postInstallSampleData), but if you don't install sample data, some things need to be changed also...

in 3.5.1 the issue is there but there is no warning.
so it seems in latest staging a new warning is there (IMO correct) and this issue was previous masked because joomla didn't send a warning.

in conclusion the problem is there for some time, but masked.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Jul 2016

please test #11245

avatar andrepereiradasilva andrepereiradasilva - change - 22 Jul 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-07-22 13:27:16
Closed_By andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - close - 22 Jul 2016

Add a Comment

Login with GitHub to post a comment