[#11229] - Two search modules on same page: Invalid HTML.
- Fixed in Code Base
- 2 Sep 2016
- Medium
- Build: staging
- # 11229
- Diff
- bertmert:patch-9
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Added module id to attributes id and for to have vaild HTML.
Fixed JQuery conflict in Beez3 (role="search").
Testing Instructions
- Create 2 modules of type mod_search on same page.
- Validate page on https://validator.w3.org/ or just check HTML source code of page. 2 times
id="mod-search-searchword". This is invalid HTML.
Apply patch.
Test again
Test also FORM tags in template Beez3 with Firebug that both mod_search forms get a
role="search"via JQuery.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Modules |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11229.
| Category | Front End Modules | ⇒ | Front End Modules Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11229.
I have tested this item
Now search module label and input have different ID. "mod-search-searchword" concatenated with module ID. And both form have role="search".
Both working perfectly, no issue found with multiple search on same page.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11229.
I have tested this item
Yes got the issue two same ids on same page for search.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11229.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
this can have an effect on site if someone use the id but it is right to merge it. I have set the milestone to 3.7.0, this should be something we point out in the release notes
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-02 20:48:19 |
| Closed_By | ⇒ | rdeutz |
| Category | Front End Modules Templates (site) | ⇒ | Front End Modules JavaScript Templates (site) |
| Labels |
Added:
?
Removed: ? |
||
Ok, this is nice to fix,
just a small number of websites will have problem if they
same comment applies for: #11168