[#11247] - Deprecate overriding pagination functions
- Closed
- 30 Jul 2016
- Medium
- Build: staging
- # 11247
- Diff
- mbabker:deprecate-pagination-functions
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Deprecates support for all overriding pagination functions (the functions in a template's html/pagination.php file) in favor of using JLayout consistently. Except for the one added in #10982 deprecation notices are added when checking for the presence of these functions.
It is also noted that the _item_active() and _item_inactive() methods of JPagination will proxy to the joomla.pagination.link layout as of 4.0. I did not make this change in the code now because the current functions and the default layout produce different HTML so this prevents an unwanted markup change which may affect how sites are rendered.
Testing Instructions
Code review and maintainer decision.
Forward Compatibility
It is possible to create a html/pagination.php file that is compatible with the proposed use of JLayout and still be backward compatible as long as the JLayout API is available. This gist is the html/pagination.php file we use for the joomla.org site template taking advantage of pagination_list_footer() already having inbuilt JLayout support and proxying the remaining methods to compatible layouts.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11247.
| Status | Pending | ⇒ | Ready to Commit |
RTC for 3.7. Thanks Michael!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11247.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-30 14:03:01 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 7c7a783
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11247.