[#11225] - [com_content] - add articles ordering by votes, ratings
- Fixed in Code Base
- 18 Sep 2016
- Medium
- Build: 3.7.x
- # 11225
- Diff
- alikon:vote-rating
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10954 .
Summary of Changes
enable article ordering by votes or by rating on backend & frontend when content vote plugin is enabled
- added articles order options (vote asc, voted desc, rating asc, rating desc)
- added rating and vote columns
- added articles Lists Layout options (show vote, show ratings)
- added articles order option in shared ( vote, rating)
- added column vote , rating on frontend list layout
- module articles category - added option to sort article by vote, rating
history see #10989
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration Components Postgresql MS SQL Language & Strings Modules Front End Installation Libraries |
| Labels |
Added:
?
?
|
||
JPluginHelper::isEnabled
What about using class ContentModelArticles in others modules / extensions?
Do we have always load votes if the plugin is enabled?
Retested and found a few small issues
Please reorder the dropdown select so that it matches the column order ie move ID to the end
-
The visual indicator of the sort direction is being displayed on the ID column and not the rating or votes column
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11225.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11225.
For greater flexibility I suggest to add something like:
if ($params->get('list_show_votes', 0) || $params->get('list_show_ratings', 0))
{
$this->setState('load_votes', JPluginHelper::isEnabled('content', 'vote'));
}at populateState https://github.com/joomla/joomla-cms/pull/11225/files#diff-e5b3effc5f60b387662db42517e31654L129
This way modules won't need to load votes, better performance.
IMHO If some category does not like to show votes then sql for votes should not be added.
and at getListQuery method then you can use if ($this->getState('load_votes', false)).
@csthomas my branch is public feel free to submit a PR
@brianteeman fixed your reported issues
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11225.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11225.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
rdeutz
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Are these database queries compatible with postgres and mssql?
@wilsonge if your concern are about COALESCE() and NULLIF() :
- for postgresql my answer is yes
- for mssql i'm unable to test but looking at msdn documentation (yes)
https://msdn.microsoft.com/it-it/library/ms190349.aspx
https://msdn.microsoft.com/it-it/library/ms177562.aspx
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-18 15:43:29 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
laoneo
- 
PhilETaylor
- 
I hoped that hathor would be removed from 3.7
No chance. Off you go do a PR :P
@alikon is this One ready to be retested by me and @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11225.