?
avatar pieter-groeneweg
pieter-groeneweg
21 Jul 2016

I stumbled upon this closed Issue: #7594

when setting up a module article category the dynamic way, when empty it still occupies the module position.
Could this be solved by something as simple as:

If <jdoc:include type="modules" name="left" bladibla> is not empty then continue what you wanna do...

I don't know if something like that would be possible. If so, it would be possible to include or exclude some like that in your template.. just like the countmodules..

avatar pieter-groeneweg pieter-groeneweg - open - 21 Jul 2016
avatar brianteeman
brianteeman - comment - 21 Jul 2016

There have been many attempts to do this - all have failed
But yes we should have a way of dealing with it

On 21 July 2016 at 12:02, pieter-groeneweg notifications@github.com wrote:

I stumbled upon this closed Issue: #7594
#7594

when setting up a module article category the dynamic way, when empty it
still occupies the module position.
Could this be solved by something as simple as:

If is not empty then continue what you wanna do...

I don't know if something like that would be possible. If so, it would be
possible to include or exclude some like that in your template.. just like
the countmodules..

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11226, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R5KW6FpOQ2QPAZfEezCUw2iBYwmks5qX0PFgaJpZM4JRouC
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman brianteeman - change - 21 Jul 2016
Labels Added: ?
avatar ggppdk
ggppdk - comment - 21 Jul 2016

This is an alternative to trying the "fix" countModules() which requires a B/C break

The alternative is not difficult to implement, and can be very performance wise too, it would look like:

<jdoc:addclass type="modules" name="position-7" yclass="p7" nclass="np7" />
<jdoc:addclass type="modules" name="position-8" yclass="p8" nclass="np8" />

e.g.

<div id="sidebar" class="
  <jdoc:addclass type="modules" name="position-7" yclass="span3" nclass=""/>
">
...
<main id="content" role="main" class="
  <jdoc:addclass type="modules" name="position-7" yclass="p7" nclass="np7"/>
  <jdoc:addclass type="modules" name="position-7" yclass="p8" nclass="np8"/>
">

If the position has non empty modules,

  • then we replace with yclass
  • otherwise we replace with nclass

Of course i do not mean strip tags like <p></p> that is totaly the responsibility of the module !

avatar brianteeman brianteeman - change - 22 Jul 2016
Category ⇒ Modules
avatar brianteeman
brianteeman - comment - 9 Dec 2016

I am closing this at this time as all attempts at "fixing" this have failed and we cant introduce a b/c change for this


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11226.

avatar brianteeman brianteeman - change - 9 Dec 2016
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-12-09 12:41:34
Closed_By ⇒ brianteeman
avatar brianteeman brianteeman - edited - 9 Dec 2016
avatar brianteeman brianteeman - close - 9 Dec 2016

Add a Comment

Login with GitHub to post a comment