I think it is confusing to say that this is or loading duplicate modules as the core insert module editor button uses this syntax. Instead why dont you just add the examples of the syntax in the text

Optionally can specify module style {xxxxxxxxx} and for loadmodule a specific module by title, Syntax: {loadmodule mod_login,module title}."

Obvioulsy replace xxxx with the correct syntax

I think, I got you. Before I update the PR, just want to conform with you.So, the final description will be as below.

PLG_LOADMODULE_XML_DESCRIPTION="Within content this plugin loads Module positions, Syntax: {loadposition user1} or Modules by name, Syntax: {loadmodule mod_login}. Optionally can specify module style and for loadmodule a specific module by title, Syntax: {loadmodule mod_login,module title}."

"module style {xxxxxxxxx}", We can load module using either position or title. What should I replace with "module style {xxxxxxxxx}?

yes thats correct - sorry you will have to see exactly what the syntax is
for style (I never used it)

On 15 July 2016 at 10:14, Ronak Tailored notifications@github.com wrote:

I think, I got you. Before I update the PR, just want to conform with
you.So, the final description will be as below.

PLG_LOADMODULE_XML_DESCRIPTION="Within content this plugin loads Module
positions, Syntax: {loadposition user1} or Modules by name, Syntax:
{loadmodule mod_login}. Optionally can specify module style and for
loadmodule a specific module by title, Syntax: {loadmodule mod_login,module
title}."

"module style {xxxxxxxxx}", We can load module using either position or
title. What should I replace with "module style {xxxxxxxxx}?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11068 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Ubgj5YsNlYX_2fU2sorY0rAw-uzks5qV093gaJpZM4JJM7j
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

To load module by style there is an option in Content - Load Modules plugin. So, I think no need to write syntax for style. we have to specify syntax to load module using either position or title.
and above description is enough to understand the syntax.

I have tested this item ✅ successfully on 30608e0

I have tested this item ✅ successfully on 30608e0

If we are going to do this then we should have the example code for adding the style as well

This would be in the form of
{loadmodule mod_login,module title,style}

If you can add that then we can get this merged

@RonakParmar what you mean to comment by @brianteeman so we can go on with this PR?

@RonakParmar how to go on with this PR?

@franz-wohlkoenig I already updated the PR as per @brianteeman comment.
Need some test or code review.

thanks for Info, @RonakParmar

@killoltailored @bhavikDigitalWebInfosoft can you please retest?

I have tested this item ✅ successfully on a872a50

Done code review