? ? Success
Referenced as Related to: # 11068

User tests: Successful: Unsuccessful:

avatar RonakParmar
RonakParmar
11 Jul 2016

Pull Request for Issue #11066 .

Summary of Changes

Added syntax to load duplicate module in article in Content-Load Module plugin.

Testing Instructions

Check the description of Content - Load Module plugin at back-end.

avatar RonakParmar RonakParmar - open - 11 Jul 2016
avatar RonakParmar RonakParmar - change - 11 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2016
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 11 Jul 2016

You have an extra file in this PR
administrator/components/com_banners/views/download/tmpl/default.php

avatar RonakParmar
RonakParmar - comment - 11 Jul 2016

When I have committed from my local it shows 2 files.
3b9d079

avatar RonakParmar
RonakParmar - comment - 11 Jul 2016

The the additional file is related with below pull request.

2072bbf

avatar infograf768
infograf768 - comment - 11 Jul 2016

It should not be in this PR.

avatar brianteeman
brianteeman - comment - 11 Jul 2016

It should not be in this Pull request - you need to make sure that you have a separate branch for each PR

avatar RonakParmar
RonakParmar - comment - 11 Jul 2016

I have created new branch for this PR.

avatar brianteeman
brianteeman - comment - 11 Jul 2016

Also I am not sure that this PR is correct anyway. Your new text suggests that you only need to use the title for a duplicate module. Not sure what you mean by that. And when you use the insert module plugin it always uses that syntax so your change will create confusion instead of clarity.

avatar RonakParmar
RonakParmar - comment - 11 Jul 2016

Thanks. I am cleaning it and closing it. I will send new PR with only specific changes.

avatar RonakParmar RonakParmar - change - 11 Jul 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-07-11 09:51:16
Closed_By RonakParmar
avatar RonakParmar RonakParmar - close - 11 Jul 2016
avatar RonakParmar
RonakParmar - comment - 11 Jul 2016

I have sent clean version of this PR in #11068

avatar RonakParmar RonakParmar - head_ref_deleted - 11 Jul 2016

Add a Comment

Login with GitHub to post a comment