[#11069] - _removeAdminMenus removes wrong menu items - nested table …
- Fixed in Code Base
- 11 Jul 2016
- Medium
- Build: staging
- # 11069
- Diff
- anibalsanchez:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11044.
Summary of Changes
I've restored how nested table deleted nodes until Joomla 3.5.
I think the problem was introduced as part as a code optimization that went too far here: 2819529
Testing Instructions
The key to force the bug #11044 is in the order of menu items.
-
Modify _removeAdminMenus to force an inverse order of deletion, libraries/cms/installer/adapter/component.php, line 1087
// Get the ids of the menu items $query = $db->getQuery(true) ->select('id') ->from('#__menu') ->where($db->quoteName('client_id') . ' = 1') ->where($db->quoteName('component_id') . ' = ' . (int) $id) ->order('id desc'); Install Weblinks.
- Manually add a menu item (any type)
- Install Weblinks again.
- New menu item is removed!
Apply the patch and repeat the steps to verify that menu items are not removed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Labels |
Added:
?
|
||
Testing ...
I have tested this item
Tested suggested case and a few others i could think of
(e.g. deleting the parent of a subtree of menu item or the parent category of some article categories, the subtrees are moved up as expected)
Did a file comparison too, indeed it reverts only the changes made by:
2819529
code is now same as J3.5.1
(except for the comments changes and the small dbo fix:)
#10369
that still exist (as they should)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11069.
| Status | Pending | ⇒ | Ready to Commit |
rtc. thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11069.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-11 22:33:37 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 224a7bc
tested at 3.6rc2
I replicated the issue
and confirmed patch solved it (tested with patchtester).
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11069.