? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
5 Jul 2016

Use JLayout for the html output

Summary of Changes

  • Split the layout to 2: simple and advanced
  • Added relevant script files for the initialisation (static files @ media/system/js)
  • Deprecated the Html::behaviour.simplecolorpicker and Html::behaviour.colorpicker

Testing Instructions

To test edit isis template xml and add:

                <field name="color"
                       class=""
                       type="color"
                       default="#1A3867"
                       validate="color"
                        control=""
                       label="color: " />

Changing control to control="simple" you initiate the simple mode, the advanced is the default.

Preview

Simple mode:
screen shot 2016-07-05 at 23 14 17

Advanced mode:
screen shot 2016-07-05 at 23 14 12

avatar dgt41 dgt41 - open - 5 Jul 2016
avatar dgt41 dgt41 - change - 5 Jul 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2016
Labels Added: ?
avatar dgt41 dgt41 - change - 5 Jul 2016
The description was changed
avatar brianteeman brianteeman - change - 5 Jul 2016
Category Fields JavaScript Layout
c7c17b0 5 Jul 2016 avatar dgt41 hmm
4735b35 5 Jul 2016 avatar dgt41 CS
avatar RonakParmar
RonakParmar - comment - 6 Jul 2016

Do I have to do anything extra to test this PR except applying this PR?
I have added above color code field in template.xml and works fine with applying PR, but when I have applied PR got javascript error. Please see screen dump of error.
screen shot 2016-07-06 at 00 56 36


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

avatar RonakParmar RonakParmar - test_item - 6 Jul 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 6 Jul 2016

I have tested this item successfully on 40b09b8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

avatar JoomliC
JoomliC - comment - 7 Jul 2016

I have tested this item successfully, but i can't mark it on joomla issue tracker as i can't access the website since this morning, telling me "You are a terrible, terrible person." ?
But i'm not!
@mbabker maybe you can help me ? I don't know who to contact to know why my IP is blocked from accessing issue tracker ?

Note: it happened 2 hours ago, while opening the issue tracker site on my iPhone...

avatar brianteeman
brianteeman - comment - 7 Jul 2016

@joomlic - everyone has that problem right now - its a server issue we are waiting a fix for

avatar JoomliC
JoomliC - comment - 7 Jul 2016

@brianteeman Thanks! Good to know my mobile is ok ;-)

avatar nikitadhiman nikitadhiman - test_item - 7 Jul 2016 - Tested successfully
avatar nikitadhiman
nikitadhiman - comment - 7 Jul 2016

I have tested this item successfully on 40b09b8

This is good :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

avatar JoomliC JoomliC - test_item - 7 Jul 2016 - Tested successfully
avatar JoomliC
JoomliC - comment - 7 Jul 2016

I have tested this item successfully on 40b09b8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

avatar brianteeman brianteeman - change - 7 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 7 Jul 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Jul 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 11 Jul 2016
Milestone Added:
avatar brianteeman brianteeman - change - 11 Jul 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 30 Jul 2016

Merged with 6aeb68b - thanks!

avatar wilsonge wilsonge - change - 30 Jul 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-07-30 14:19:49
Closed_By wilsonge
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2016
Category Fields JavaScript Layout Layout Libraries Fields
avatar wilsonge wilsonge - close - 30 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - close - 30 Jul 2016
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment