[#11029] - Clone the URI so we only manipulate it locally.
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 11029
- Diff
- Bakual:RemoveHitcount
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11016 .
Summary of Changes
Cloning the JURI instance before we manipulate it in the vote plugin. This way, the adjusted query will only be used for the vote plugin and doesn't change the global object.
Testing Instructions
From original Issue:
Install a multilanguage site with the automatic installation that offers Joomla. 2 languages are enough.
In Articles Options set the parameter Show Voting on Show.
In frontend click on an article and then look the url generated when you go over flags.If you click on the english article and then click on the english flag, you will see that the url change,
at the end &hitcount=0 is added
After applying the PR, the &hitcount=0 isn't added anymore to the flag, but still is in the vote button.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Plugins |
I have no clue why that single test failed, it passed locally and is completely unrelated to the changes here. I have restarted the job to see if it was a glitch.
I have tested this item
Patch tested, it solves de issue. Fantastic!
Also the Travis checks is ok now
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11029.
| Status | Pending | ⇒ | Ready to Commit |
RTC. based on tests
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11029.
| Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 11016 |
| Relation Type | ⇒ | Pull Request for | |
| Labels | |||
| Milestone |
Added: |
||
This PR has received new commits.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 18:48:35 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks Thomas, all merged :)
I have tested this item✅ successfully on cf7e1d2
Patch tested, it solves de issue.
Thanks Bakual
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11029.