Feeling Lucky
?
[#11028] - Use API for inline script in module edit page (admin)
- Closed
- 14 Aug 2016
- Medium
- Build: staging
- # 11028
- Diff
- dgt41:modulesOrderingInline
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Consistently use the API
Don't echo <script> in the document
Summary of Changes
Using addScriptDeclaration() instead of echoing the script inline in the middle of the document
Testing Instructions
Go to admin and try to edit a module. Verify that the ordering is still functional
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
killoltailored
- comment
- 8 Jul 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11028.
RonakParmar
- comment
- 8 Jul 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11028.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 8 Jul 2016
dgt41
- comment
- 28 Jul 2016
@joomla-bot rtc
andrepereiradasilva
- comment
- 28 Jul 2016
RTC
andrepereiradasilva
- comment
- 28 Jul 2016
bot is sleeping
dgt41
- comment
- 28 Jul 2016
maybe on vacation?
I have tested this item✅ successfully on d253477
? . Hopefully we get them merged fast in core, so that the tests can be automatically run.
Hey I tested this successfully.
I also ran our tests for core.js against this and those are also passing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11028.