[#11031] - Ensure params is a Registry before cloning it
- Closed
- 21 Jun 2017
- Medium
- Build: staging
- # 11031
- Diff
- manchumahara:patch-2
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Testing Instructions
situation: when you need use the site part com_content article model outside of com_content or calling model using 'ignore_request' => true
- include the model require_once JPATH_SITE . '/components/com_content/models/article.php';
- take instance of the model $articlemodel = JModelLegacy::getInstance('Article', 'ContentModel', array('ignore_request' => true));
//see I used 'ignore_request' => true and in such case the param object stored in state in null or not an object. - $articlemodel->setState('article.id', 1); //suppose I need info for article of id 1 (i hard coded it for testing)
- $article = $articlemodel->getItem(); //get the information
Error: php error " __clone method called on non-object in ...." for line $data->params = clone $this->getState('params'); as the param object is empty and can not be clone.
So the quick fix can be
//$data->params = clone $this->getState('params');
$tempparams = $this->getState('params');
if(is_object($tempparams)){
$data->params = clone $tempparams;
}
else{
$data->params = new Registry;
}
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I have a query to experts. The issue I noted in this pull request same issue exists in another core model like site part single contact model, banner etc or if we look again. This is because extension developer like me try to use the core models without writing the sql query once again and can face same issue. I can send more pull request for same type issue in other core model,
I think it's reasonable to harden the code to cope with the possibility that params might be empty.
However, I think your code can be simplified to remove the else clause.
Also, please bear in mind that the core extension classes are NOT subject to our backwards-compatibility promise, so extending from them is something you should undertake only on the understanding that your code might break on a minor version upgrade, although the probability is very low for the remainder of the 3.x series.
brianteeman
- | Category | ⇒ | Components |
This PR needs to be synchronized to the current development branch to be tested/reviewed. Also, the commented out code should be removed.
| Title |
|
||||||
| Title |
|
||||||
| Category | Components | ⇒ | Front End com_content Components |
| Status | Pending | ⇒ | Information Required |
If this PR get no Response, it will be closed at 22th June 2017.
This PR is waiting from july 6, 2016 !
I don't know how can I resolve the conflict as the main branch code already changed after my PR. Either someone help on this or close this PR.
How to help @manchumahara to synchronize his PR?
ping @rdeutz as Release Leader 3.7 if he knows one who can help @manchumahara to synchronize.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11031.
This need a bit more, you are only checking is it is an object but the title says your check is if it is a registry. Closing because recreate a PR is easier
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-21 12:15:22 |
| Closed_By | ⇒ | rdeutz |
@manchumahara Please see CS PR manchumahara#1