[#10926] - Multilanguage: Prevent display of the edit associations view when the item is new or its language is set to All.
- Fixed in Code Base
- 21 Jul 2016
- Medium
- Build: staging
- # 10926
- Diff
- infograf768:edit_assoc
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
See #10913
Before this patch, one could access the Edit Associations view through the Associations tab, even when the item was new or its language was set to "All languages".
The Association tab would show All existing Content Languages which made no sense. Example for a multilingual site with 7 languages, we would get all 7 languages instead of 6 possibilities:
Until this PR, one would only get a Message after Save or Save and Close the item (#10913)
We had 2 solutions: one was to not display the Associations tab at all when the item was new and/or when its language was set to All.
I chose to go on displaying the Associations tab to avoid confusion and just display an alert in it.
To test, install a multilang site.
Create a new item (article, category, contact, newsfeed, menu item) and before save, go to the Associations tab.
Or edit an item which language have been set to ALL and go to the Associations tab.
One should now get
@brianteeman
Please look at the new string value.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10926.
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10926.
Done, we now get:
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10926.
I have tested this item
Tested all 5 forms, switching language, worked as expected / described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10926.
| Status | Pending | ⇒ | Ready to Commit |
RTC based on tests. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10926.
| Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Language & Strings Multilanguage |
| Labels | |||
roland-d
- | Milestone |
Added: |
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-21 20:24:31 |
| Closed_By | ⇒ | wilsonge |
bot please
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on bf4dff4
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10926.