Feeling Lucky
?
[#10925] - Miscellaneous Doc Block Tweaks
- Fixed in Code Base
- 27 Jun 2016
- Medium
- Build: staging
- # 10925
- Diff
- mbabker:doc-block-urls
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Removes links to the docs wiki for JTable; many of these don't exist or represent the Joomla 1.5 API
- Changes links for
php.netto consistently use thehttps://secure.php.netmirror - Changes all GitHub links to use https to avoid a needless redirect when the API site's docs are compiled
- Other miscellaneous link updates to remove needless redirects
- Minor formatting tweaks on some JTable doc blocks (this mostly impacts how some stuff renders when the API site's compiled)
Testing Instructions
Review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style Documentation |
zero-24
- comment
- 24 Jun 2016
I have tested this item
Looks ok from Review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 24 Jun 2016
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
zero-24
- comment
- 25 Jun 2016
@mbabker we have a travis error here:
1) JDatabaseIteratorPostgresqlTest::testForEach with data set #0 ('title', '#__dbtest', null, 'stdClass', 0, 0, array(stdClass Object (...), stdClass Object (...), stdClass Object (...), stdClass Object (...)), null)
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
0 => stdClass Object (
- 'title' => 'Testing'
+ 'title' => 'Testing2'
)
1 => stdClass Object (
- 'title' => 'Testing2'
+ 'title' => 'Testing3'
)
2 => stdClass Object (
- 'title' => 'Testing3'
+ 'title' => 'Testing4'
)
3 => stdClass Object (
- 'title' => 'Testing4'
+ 'title' => 'Testing'
)
)
But the funny thing is this PR just change doc blocks?! Maybe we need just to restart the travis job?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.
| Labels |
Removed:
?
|
||
ghazal
- comment
- 25 Jun 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 27 Jun 2016
Set back to RTC - no idea why it says there are failures with Travis - it looks ok to me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-27 21:46:01 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on a00e0f3
On review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.