? Success
Related to # 10934

User tests: Successful: Unsuccessful:

avatar RonakParmar
RonakParmar
25 Jun 2016

Pull Request for Issue #10911 .

Summary of Changes

Added basic div structure of label and field.

Testing Instructions

Goto->components->Banners->Tracks
Click on Export button, pop-up will appear.
Hove label on the pop-up and check position of the tooptip.

avatar RonakParmar RonakParmar - open - 25 Jun 2016
avatar RonakParmar RonakParmar - change - 25 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2016
Labels Added: ?
avatar ggppdk
ggppdk - comment - 25 Jun 2016

It works, but if you do a search for

if ($field->hidden)

In most cases you will see the hidden fields are added without a container:

<?php if ($field->hidden) : ?>
    <?php echo $field->input; ?>
<?php else: ?>

but there are a couple that add the container to hidden field, which results in undesired spacing

  • i know, that in this case

neither the XML file has any hidden fields,
nor are any hidden fields created dynamically and added to the form

avatar kalpesh681 kalpesh681 - test_item - 25 Jun 2016 - Tested successfully
avatar kalpesh681
kalpesh681 - comment - 25 Jun 2016

I have tested this item successfully on 2072bbf


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10927.

avatar hardiktasol hardiktasol - test_item - 25 Jun 2016 - Tested successfully
avatar hardiktasol
hardiktasol - comment - 25 Jun 2016

I have tested this item successfully on 2072bbf

Now tooltip showing above label.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10927.

avatar ggppdk
ggppdk - comment - 25 Jun 2016

It works,
but the container does not have enough room at the top to show the tooltip of the "File name" field, tooltip is cut-off

avatar andrepereiradasilva
andrepereiradasilva - comment - 25 Jun 2016

@JoomliC can you check if this one also?

avatar JoomliC
JoomliC - comment - 25 Jun 2016

@andrepereiradasilva Thank you to alert me on this PR! ;-)
I was too busy last 10 days to keep working on modals improvement, but i'm back a bit at it.
This one is one of the modals i don't have yet full reviewed (but in process).

Well... i have almost a PR ready for this one, but with more changes to integrate better in a bootstrap modal.
In the same time, my purpose is to use a new layout for toolbar modal button (as no generic one excepted the "popup" one, but not best for BS modal). My goal was to improve modal button in toolbar (batch modals, settings in com_messages...)

About this PR, i have indeed a few comments (and this one is not ok to be commit IMO) :

  • as content view loading in a iframe, the tooltip placement should be bottom (top is not possible when iframe in a bootstrap modal, as truncated at top).
  • The code style is not ok.

There a preview of what i've already done (and if needed, i can finish a PR for this one this week-end) :
capture d ecran 2016-06-25 a 17 04 16

As you can see, more changes :

  • No tooltip for base name, as description is a bit long (and not always easy to use tooltip when long description).
  • Tooltip placement bottom for Compressed label
  • Buttons in the BS modal footer
  • Using new viewport dimensions
  • appendButton using a new toolbar button layout :
$selector   = $displayData['selector'];
$class      = isset($displayData['class']) ? $displayData['class'] : 'btn btn-small';
$icon_class = isset($displayData['icon_class']) ? $displayData['icon_class'] : 'icon-out-3';
$title      = isset($displayData['title']) ? $displayData['title'] : '';
?>
<button class="<?php echo $class; ?>" data-toggle="modal" data-target="#<?php echo $selector; ?>">
    <span class="<?php echo $icon_class; ?>" title="<?php echo $selector; ?>"></span>
    <?php echo $title; ?>
</button>

As you can see, i have tried to do a generic button layout to open a modal, which one is generated directly in the view file (for tracks download, directly generated in tracks view).

avatar brianteeman
brianteeman - comment - 26 Jun 2016

That looks good @joomlic


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10927.

avatar brianteeman brianteeman - change - 26 Jun 2016
Category Authentication UI/UX
avatar JoomliC
JoomliC - comment - 26 Jun 2016

I have just created a PR with the new toolbar button layout, and full refactory of the com_banners tracks export modal : #10934
;-)

avatar gunjanpatel gunjanpatel - change - 27 Jun 2016
Rel_Number 0 10934
Relation Type Related to
avatar gunjanpatel gunjanpatel - change - 27 Jun 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-06-27 06:48:49
Closed_By gunjanpatel
avatar gunjanpatel
gunjanpatel - comment - 27 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - close - 27 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - close - 27 Jun 2016
avatar gunjanpatel
gunjanpatel - comment - 27 Jun 2016

Closing as it is going to be fixed in #10934


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10927.

Add a Comment

Login with GitHub to post a comment