User tests: Successful: Unsuccessful:
Pull Request for Issue #10911 .
Added basic div structure of label and field.
Goto->components->Banners->Tracks
Click on Export button, pop-up will appear.
Hove label on the pop-up and check position of the tooptip.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
I have tested this item
I have tested this item
Now tooltip showing above label.
It works,
but the container does not have enough room at the top to show the tooltip of the "File name" field, tooltip is cut-off
@andrepereiradasilva Thank you to alert me on this PR! ;-)
I was too busy last 10 days to keep working on modals improvement, but i'm back a bit at it.
This one is one of the modals i don't have yet full reviewed (but in process).
Well... i have almost a PR ready for this one, but with more changes to integrate better in a bootstrap modal.
In the same time, my purpose is to use a new layout for toolbar modal button (as no generic one excepted the "popup" one, but not best for BS modal). My goal was to improve modal button in toolbar (batch modals, settings in com_messages...)
About this PR, i have indeed a few comments (and this one is not ok to be commit IMO) :
There a preview of what i've already done (and if needed, i can finish a PR for this one this week-end) :
As you can see, more changes :
$selector = $displayData['selector'];
$class = isset($displayData['class']) ? $displayData['class'] : 'btn btn-small';
$icon_class = isset($displayData['icon_class']) ? $displayData['icon_class'] : 'icon-out-3';
$title = isset($displayData['title']) ? $displayData['title'] : '';
?>
<button class="<?php echo $class; ?>" data-toggle="modal" data-target="#<?php echo $selector; ?>">
<span class="<?php echo $icon_class; ?>" title="<?php echo $selector; ?>"></span>
<?php echo $title; ?>
</button>
As you can see, i have tried to do a generic button layout to open a modal, which one is generated directly in the view file (for tracks download, directly generated in tracks view).
That looks good @joomlic
Category | ⇒ | Authentication UI/UX |
Rel_Number | 0 | ⇒ | 10934 |
Relation Type | ⇒ | Related to |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-27 06:48:49 |
Closed_By | ⇒ | gunjanpatel |
Set to "closed" on behalf of @gunjanpatel by The JTracker Application at issues.joomla.org/joomla-cms/10927
Closing as it is going to be fixed in #10934
It works, but if you do a search for
In most cases you will see the hidden fields are added without a container:
but there are a couple that add the container to hidden field, which results in undesired spacing
neither the XML file has any hidden fields,
nor are any hidden fields created dynamically and added to the form