[#10884] - Add Sortable Function to Repeatable
- Closed
- 13 Aug 2016
- Medium
- Build: staging
- # 10884
- Diff
- nielsnuebel:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Function
Summary of Changes
I have change the JFormFieldRepeatable i add DropDown Sortablefunction like the ordering in Articles
and fix the repeatable.js for displaying images preview after select an image in the Repeatable Modalbox
Testing Instructions
Install the Test Modul from here https://github.com/nielsnuebel/mod_testrepeatable/releases/tag/1.0.1 Download the Zip File.
After you have install the Modul go to Extensions->Moduls and create a new Modul from Type "Test Sortable Repeatable Field"
Add a Title and a Modul Position like position-7
Modul Assignment "On all pages"
Go to the Tab "Module" and add two Items - click on the Button "Select" a Modal Box will popup
First item Title "Title 1" and image choose what you want, check first if the Preview Box will shown the image
Second item "Title 2" and a image Click Save in the Modalbox and
Click Save to save the changes
Go to the Frontend and check the result, there is a Unsortlist with a headline and a image
go to the Module in the Backend and click the Button Select and put the Second item over the first item, for that click on the three lines on the left side and hold the mouse down and drag it over the first row.
Save the repeatable changes and the module change and check the result on the frontpage
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Please Download the Version 1.0.1 in 1.0.0 i forgot the helper.php
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10884.
should be
jQuery(document).ready(function($) { $("#' . $this->id . '_table tbody").sortable(); });
I have one question. Is it possible to put this helper Function Module Helper global to Joomla in a core lib?
brianteeman
- | Category | ⇒ | Fields |
I have test this, but was not able to put the Second item over the first item.
There are no three lines on the left side.
Tested on Firefox, W7 on joomlapbf.com site
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10884.
I have tested this item
Without the patch I couldn't move and sort anything.
The patch fixed it.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10884.
I have tested this item
Without the patch I couldn't move and sort anything.
The patch fixed it.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10884.
Tested again (and now I understand how to test...) and test succesfull. I amable to sort the images.
But, there are no images visible (see screenshot). Tested with W7, FF.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10884.
| Status | Pending | ⇒ | Ready to Commit |
RTC based on testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10884.
| Labels |
Added:
?
|
||
I wonder like @schnuti if this is not best done for the JFormFieldSubform. What do you think @nielsnuebel ?
@roland-d until now I have not yet tested the JFormFieldSubform, but maybe at night.
Can someone answer my question Method getRepeatable . It would be cool if this Method everywhere in Joomla accessable
I have one question. Is it possible to put this helper Function Module Helper global to Joomla in a core lib?
no, I think. Because JFormFieldRepeatable is deprecated.
Also JFormFieldSubform already support sorting.
Please use new field.
| Category | Fields | ⇒ | Libraries JavaScript Fields |
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 21:31:51 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Nice!?