[#10883] - [bump.php] Replace also __DEPLOY_VERSION__ by the build release
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10883
- Diff
- andrepereiradasilva:patch-7
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR updates bump.php to replace the string __DEPLOY_VERSION__ by the current release (if needed).
Testing Instructions
- Change a since tag in any php file to
__DEPLOY_VERSION__. - Run
php build/bump.php -v 3.6.0-beta2(or current version, if other) - Check the since tag in the file you changed before is now
3.6.0.
Observations
This allow to not worry anymore about the since tag. Just but __DEPLOY_VERSION__ on the PR code and when a version bump is done it will be replaced by the release version.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
i don't think it's a pre-requisite for bump.php to work on php memory limit of 128MB :)
no change ? are you sure? what is the output of the script?
brians-MacBook-Air:github-joomla-cms brian1$ /Applications/MAMP/bin/php/php5.5.26/bin/php build/bump.php -v 3.6.0-beta2
Version data:
- Main: 3.6
- Release: 3.6.0
- Full: 3.6.0-beta2
- Build:
- Dev Level: 0-beta2
- Dev Status: Beta
- Release date: 21-June-2016
- Release time: 11:53
- Release timezone: GMT
- Creation date: June 2016
what is the file you changed?
Changed two
administrator/components/com_admin/controllers/profile.php
plugins/system/highlight/highlight.php
ok will test those
[user@host build]# php bump.php -v 3.6.0-beta2
Version data:
- Main: 3.6
- Release: 3.6.0
- Full: 3.6.0-beta2
- Build:
- Dev Level: 0-beta2
- Dev Status: Beta
- Release date: 21-June-2016
- Release time: 12:03
- Release timezone: GMT
- Creation date: June 2016
- Since Version changed in 2 files.
Version bump complete!Are you sure you added __DEPLOY_VERSION__?
yes and I just tried again with a copy paste
brian i can't reproduce your issue.
Just checked php error log and that still shows a memory error even though its not logged to the screen - weird - must be me
I have tested this item
After applying the patch the DEPLOY_VERSION has been changed to 3.6.0 as expected. I did have to increase memory to 512MB to get the bump script to work though ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10883.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 22:22:50 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item? unsuccessfully on c2407f9
## With Patch
brians-MacBook-Air:github-joomla-cms brian1$ php build/bump.php -v 3.6.0-beta2
Version data:
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 151553344 bytes) in /Applications/MAMP/htdocs/github-joomla-cms/build/bump.php on line 305
Without patch
brians-MacBook-Air:github-joomla-cms brian1$ php build/bump.php -v 3.6.0-beta2
Version data:
Version bump complete!
brians-MacBook-Air:github-joomla-cms brian1$
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10883.