Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10747] - Fix IE11 undefined variable

? Success

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
7 Jun 2016

Summary of Changes

In IE (11) on a disabled pulldown field in this file we have the JavaScript error: isPatternMismatched is not defined. Initializing the field solves the problem.

The isDisabled variable is unused, so removed this as well.

Testing Instructions

Will follow, creating this PR so this change won't get lost. If you look at the code itself you can see the coding mistakes.

@ottoh001 Please provide the test instructions

avatar roland-d roland-d - open - 7 Jun 2016
avatar roland-d roland-d - change - 7 Jun 2016
Status New ⇒ Pending
avatar roland-d roland-d - change - 7 Jun 2016
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 Jun 2016
Category ⇒ JavaScript
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2016
Milestone Removed:
avatar killoltailored
killoltailored - comment - 8 Jul 2016

Please provide test instruction

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10747.

avatar C-Lodder
C-Lodder - comment - 15 Aug 2016

@roland-d You've removed the isDisabled variable so this conditional statement will never be checked:

https://github.com/roland-d/joomla-cms/blob/2ea754e968e3ddb6166c537f153d5a5ee36e218a/media/system/js/html5fallback-uncompressed.js#L151

avatar roland-d
roland-d - comment - 15 Aug 2016

@C-Lodder Thank you for reminding me of this PR. I am going to close it because I made this for @ottoh001 and since he is not responding. No use to pursue it.

avatar roland-d roland-d - change - 15 Aug 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-08-15 20:21:01
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 15 Aug 2016

Add a Comment

Login with GitHub to post a comment