Moved from joomla-projects/joomla-pythagoras#62 opened by @mbabker
The manner in which the application uses the session should be refactored. Key issues:
JApplicationCms::__construct()
codes a default behavior to use sessions which are manually started in the constructor's context; the loadSession()
method should be extracted into a service provider and the call to $session->start()
removed from the application's bootup sequenceJApplicationCms::checkToken()
forces a session record to be written to the #__session
table regardless of the session handler typeJApplicationCms::checkToken()
also performs functions that belong to the session handler's garbage collection mechanism (see ignored PR #6608)Category | ⇒ | Libraries |
Labels |
Added:
?
|
I've got open PRs trying to deal with some things, assuming those ever get tested/merged it should cover at least the first point (the latter two aren't easily dealt with).
Shall I close this then - the tracker isnt a todo list?
On 23 August 2016 at 21:09, Michael Babker notifications@github.com wrote:
I've got open PRs trying to deal with some things, assuming those ever get
tested/merged it should cover at least the first point (the latter two
aren't easily dealt with).—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10746 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R6jLDitMioxaskW6u2qbUedHmgCks5qi1NkgaJpZM4Iv64H
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Consider it a feature request. Core needs to be decoupled from the requirement to log session metadata to the database, or at least make this optional.
Category | Libraries | ⇒ | Feature Request Libraries |
Status | New | ⇒ | Needs Review |
Labels |
Added:
?
|
Between the changes already in 4.0 and open pull requests, the main issue here is as good as things are going to get.
Status | Needs Review | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-25 01:56:01 |
Closed_By | ⇒ | mbabker |
@mbabker has this been addressed now?
(/me doesnt like using the issue tracker as a todo list)