? ?
avatar nibra
nibra
7 Jun 2016

Moved from joomla-projects/joomla-pythagoras#62 opened by @mbabker

The manner in which the application uses the session should be refactored. Key issues:

  • JApplicationCms::__construct() codes a default behavior to use sessions which are manually started in the constructor's context; the loadSession() method should be extracted into a service provider and the call to $session->start() removed from the application's bootup sequence
  • JApplicationCms::checkToken() forces a session record to be written to the #__session table regardless of the session handler type
  • JApplicationCms::checkToken() also performs functions that belong to the session handler's garbage collection mechanism (see ignored PR #6608)
avatar nibra nibra - open - 7 Jun 2016
avatar brianteeman brianteeman - change - 8 Jun 2016
Category ⇒ Libraries
avatar brianteeman brianteeman - change - 8 Jun 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 23 Aug 2016

@mbabker has this been addressed now?

(/me doesnt like using the issue tracker as a todo list)

avatar mbabker
mbabker - comment - 23 Aug 2016

I've got open PRs trying to deal with some things, assuming those ever get tested/merged it should cover at least the first point (the latter two aren't easily dealt with).

avatar brianteeman
brianteeman - comment - 23 Aug 2016

Shall I close this then - the tracker isnt a todo list?

On 23 August 2016 at 21:09, Michael Babker notifications@github.com wrote:

I've got open PRs trying to deal with some things, assuming those ever get
tested/merged it should cover at least the first point (the latter two
aren't easily dealt with).

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10746 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R6jLDitMioxaskW6u2qbUedHmgCks5qi1NkgaJpZM4Iv64H
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar mbabker
mbabker - comment - 23 Aug 2016

Consider it a feature request. Core needs to be decoupled from the requirement to log session metadata to the database, or at least make this optional.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2016
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 23 Aug 2016
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Apr 2017
Category Libraries ⇒ Feature Request Libraries
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Apr 2017
Status New ⇒ Needs Review
avatar brianteeman brianteeman - change - 6 Apr 2017
Labels Added: ?
avatar brianteeman brianteeman - labeled - 6 Apr 2017
avatar mbabker
mbabker - comment - 25 May 2017

Between the changes already in 4.0 and open pull requests, the main issue here is as good as things are going to get.

avatar mbabker mbabker - change - 25 May 2017
Status Needs Review ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-05-25 01:56:01
Closed_By ⇒ mbabker
avatar mbabker mbabker - close - 25 May 2017

Add a Comment

Login with GitHub to post a comment