? ? ? Pending

User tests: Successful: Unsuccessful:

avatar nibra
nibra
7 Jun 2016

Pull Request for Issue #10744.

Note: The great number of changed files is caused by updated dependencies in the vendor folder.

Summary of Changes

Current PHPUnit tests are moved to tests.phpunit.
Codeception was added as test framework.
Test structure for Codeception was added.
Requires PHP 5.5

Testing Instructions

Tests work in Travis, so no manual testing needed.

avatar nibra nibra - open - 7 Jun 2016
avatar nibra nibra - change - 7 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2016
Labels Added: ? ? ?
avatar mbabker
mbabker - comment - 7 Jun 2016

This PR can't be tested/reviewed/acted upon until a proper 4.0 project has started somewhere. Also this PR can't be considered for 3.x since it raises minimum PHP dependencies. My suggestion is to close this until there's a proper 4.0 branch/project somewhere then this PR be opened against that.

// @wilsonge

avatar nibra
nibra - comment - 7 Jun 2016

Raising the PHP requirements is already in the pipeline.
So, instead of closing this, opening a 4.0-dev branch makes more sense to me.

avatar mbabker
mbabker - comment - 7 Jun 2016

You'd still have to close & re-open the PR against that branch unless whomever is maintaining it will manually cherry-pick this PR onto it or GitHub finally added the feature that lets you change a PR's target branch.

I'm just trying to save time for folks looking at PRs right now so they aren't looking at or commenting on stuff that isn't applicable.

avatar nibra
nibra - comment - 7 Jun 2016

Ah ok, got you.

avatar brianteeman
brianteeman - comment - 7 Jun 2016

We really want to try and not turn the issue tracker into a to-do list

avatar mbabker
mbabker - comment - 7 Jun 2016

Whatever space Joomla 4 ever ends up living in is either going to have a GitHub issue log full of todo tasks or require an external resource as a project management board for items like that. It's not something that can be avoided unfortunately.

avatar wilsonge wilsonge - change - 7 Jun 2016
Milestone Added:
avatar brianteeman brianteeman - change - 8 Jun 2016
Labels
avatar brianteeman brianteeman - change - 8 Jun 2016
Category Unit Tests
avatar nibra nibra - change - 10 Jun 2016
Labels
avatar mbabker
mbabker - comment - 21 May 2017

@rdeutz As this is your team's area if this is something we want to work on IMO we probably should come up with a migration plan.

avatar rdeutz
rdeutz - comment - 22 May 2017

A proper plan would be great, maybe we can sit together at JAB17, closing it for now.

avatar rdeutz rdeutz - change - 22 May 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-22 09:18:03
Closed_By rdeutz
avatar rdeutz rdeutz - close - 22 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2017
Category Unit Tests Repository Unit Tests External Library Libraries

Add a Comment

Login with GitHub to post a comment