[#10679] - remove double space
- Fixed in Code Base
- 1 Jun 2016
- Medium
- Build: staging
- # 10679
- Diff
- brianteeman:doublespce
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The message about installing the "Install from Web" plugin has two hard coded spaces between the strings. The style guide "https://joomla.github.io/user-interface-text/?user-interface-text/punctuation.md" says we should only have one.
Both hard coded spaces are removed because the browser interprets the tabs as a space so isnt needed at all
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10679.
Added the same change to the hathor override
maybe you should do the same in isis
Isis doesnt need any nobreak spaces as it has all those tabs to force the ode on a new line
ok then
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10679.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10679.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-01 18:59:15 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
I have tested this item✅ successfully on abfa7f2
Makes sense
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10679.