? ? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
30 May 2016

Partial Pull Request for Issue #10604

Summary of Changes

Adds support for the Bootstrap 3 alert-link class to make links stand out more and implement it in the Install from Web alert

Testing Instructions

Apply the patch and navigate to administrator/index.php?option=com_installer; note that the links stand out more now.

Before:
screen shot 2016-05-30 at 11 50 39 am

After:
screen shot 2016-05-30 at 11 50 55 am

avatar mbabker mbabker - open - 30 May 2016
avatar mbabker mbabker - change - 30 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 30 May 2016
Category Templates (admin)
avatar brianteeman brianteeman - change - 30 May 2016
Labels
avatar zero-24
zero-24 - comment - 1 Jun 2016

@mbabker maybe we want to add it to the download message at com_joomlaupdate here too? (as that was the point that got reported)

The state now works as expected

avatar mbabker
mbabker - comment - 1 Jun 2016

It wasn't my intent to review every use of an alert and add the class, just adding it in one spot to make it easy to demonstrate. If accepted, then the work to go through and make the changes can begin.

avatar roland-d roland-d - test_item - 4 Jun 2016 - Tested successfully
avatar roland-d
roland-d - comment - 4 Jun 2016

I have tested this item successfully on 8d69485

The links in the Install from Web are regular light blue links, after applying the patch the links are now bold and stand out more.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10678.

avatar alikon alikon - test_item - 6 Jun 2016 - Tested successfully
avatar alikon
alikon - comment - 6 Jun 2016

I have tested this item successfully on 8d69485


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10678.

avatar brianteeman brianteeman - change - 6 Jun 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 6 Jun 2016

Rtx


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10678.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 6 Jun 2016
Milestone Added:
avatar wilsonge wilsonge - change - 7 Jun 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-06-07 19:37:30
Closed_By wilsonge
avatar zero-24
zero-24 - comment - 8 Jun 2016

@joomla-cms-bot can we have your helping hand here too?

avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment