[#10680] - [build/bump] Make bump update the links in the readme files also (md and txt)
- Fixed in Code Base
- 1 Jun 2016
- Medium
- Build: staging
- # 10680
- Diff
- andrepereiradasilva:patch-9
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Simple PR. Make bump.php script update the versions and links in readme files also.
Testing Instructions
Code review, or:
1. Apply patch
2. Run php build/bump.php -v 3.7.0in joomla staging root
3. Check the readme files test links are changed
Hint: run php build/bump.php -v 3.6.0-alpha2 to reset to previous version
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | CLI |
yes I know - that was my PR ;)
My point was that wont this PR change that from 3.x to 3.x.y which will
break the link
`https://docs.joomla.org/Joomla_3.6_version_history
On 30 May 2016 at 18:39, andrepereiradasilva notifications@github.com
wrote:
@brianteeman https://github.com/brianteeman see
https://github.com/joomla/joomla-cms/pull/10193/files—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10680 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8Z9xYgLC0onxigD3M_dVtfrE_yklks5qGyDWgaJpZM4Ip8Zk
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
brian it will not change.
please test
Version data:
- Main: 3.7
- Release: 3.7.1
- Full: 3.7.1-alpha1
- Build:
- Dev Level: 1-alpha1
- Dev Status: Alpha
- Release date: 30-May-2016
- Release time: 18:17
- Release timezone: GMT
- Creation date: May 2016it uses the main version, not the release
If I read this PR correctly then the full 3.x.y will be used which will cause issues with the links
And i didnt
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10680.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10680.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10680.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-01 19:05:09 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
This is not correct. The readme file only refers to 3.x and not 3.x.y. If I read this PR correctly then the full 3.x.y will be used which will cause issues with the links