[#10641] - [html5] System frontend template
- Closed
- 3 Sep 2016
- Medium
- Build: staging
- # 10641
- Diff
- andrepereiradasilva:html5-system-site
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is a redo of #9842 for system site only.
This PR does a basic conversion of system site template to HTML5.
Also made some minor corrections:
- Use the API in inline css/js (except error page)
- Use ie9 or lower hml5.js in all files.
Testing Instructions
- Install patch
- Add the following code to force the system template in the frontend (before https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/application/site.php#L422)
$this->template = new stdClass;
$this->template->template = 'system';
$this->template->params = new Registry;-
Go to frontend and check if the the following pages are working properly (they don't have style):
- component popup (add
?tmpl=component&print=1to an existent page) - error pages (test one non existent URL)
- offline (set the site to offline and check the login page)
- component popup (add
Remove the code added in 2. and check all is again ok and with style.
Check also the code changes.
Observations
All pages should now start with this code:
<!DOCTYPE html>
<html lang="en-gb" dir="ltr">
<head>
[...]
<meta charset="utf-8" />
[...]| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Templates (site) |
What's the issue? The system templates don't really have any of their own styling for general use. Here you're mainly focused on the actual HTML output and that there aren't any errors versus the visual aesthetics.
@RonakParmar that is not a problem. it works like that.
I have applied this PR and added above code in given path file and line number.
Here is the screen-shots of my site before PR apply and after PR and above code applied.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.
First screen-shot is after PR applied and code added.
Second screen-shot is before PR apply.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.
Without hacking core, you can't use the system template for general use (except the error.php layout because of a hardcoded fallback). So the fact your before screenshot is using Protostar tells me you don't have a hack in place to force the system template.
@RonakParmar the code in the test instructions is exactly to force the system template (you can't select the system template in templates so we need to do this).
so for me it seems your test (first print screen) is a success.
@andrepereiradasilva So, After adding that code my site is not working properly, Is it successful test?
yes, remove the custom code added and you will see it's working correctly with the patch applied.
Okay, testing. Thanks for the update.
Yes, without the code added, this PR works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.
Please mention that, after removing the code front-end will work fine, in testing instruction, so people like me get idea and otherwise they perform same thing that I have done. :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.
added to test instructions, thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
roland-d
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 11:35:44 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
| Category | Templates (site) | ⇒ | Templates (site) Front End |
I have tested this item? unsuccessfully on e4834ef
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10641.