? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
26 May 2016

Summary of Changes

This is a redo of #9842 for beez3 only.

This PR does a basic conversion of beez3 template to HTML5.
Also made some minor corrections:

  • Use the API in inline css/js (except error page)
  • Use ie9 or lower hml5.js in all files.

Testing Instructions

  1. Install patch
  2. Set the site template as "beez3" (if not yet)
  3. Go to frontend and check if the the following pages are working properly:
    • normal page (test any existent URL)
    • component popup (add ?tmpl=component&print=1 to an existent page)
    • error pages (test one non existent URL)

Check also the code changes.

Observations

All pages should now start with this code:

<!DOCTYPE html>
<html lang="en-gb" dir="ltr">
<head>
[...]
    <meta charset="utf-8" />
[...]
avatar andrepereiradasilva andrepereiradasilva - open - 26 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 26 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 26 May 2016
Category Templates (site)
avatar bertmert bertmert - test_item - 12 Jun 2016 - Tested successfully
avatar bertmert
bertmert - comment - 12 Jun 2016

I have tested this item successfully on c038a37


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.

avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Jun 2016

This PR has received new commits.

CC: @bertmert


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.

avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Jun 2016

This PR has received new commits.

CC: @bertmert


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jun 2016

changes made:

  • Updated branch
  • removed $doc in favour of $this
avatar anjahage anjahage - test_item - 25 Jun 2016 - Tested successfully
avatar anjahage
anjahage - comment - 25 Jun 2016

I have tested this item successfully on c38bda6

Another successful test according the test instructions.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.

avatar andrepereiradasilva
andrepereiradasilva - comment - 25 Jun 2016

@bertmert can you retest?

avatar joomlara joomlara - test_item - 25 Jun 2016 - Tested successfully
avatar joomlara
joomlara - comment - 25 Jun 2016

I have tested this item successfully on c38bda6

Tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.

avatar zero-24 zero-24 - change - 25 Jun 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 25 Jun 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10640.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2016
Labels Added: ?
avatar roland-d
roland-d - comment - 25 Jun 2016

Thanks everybody

avatar roland-d roland-d - change - 25 Jun 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-06-25 13:44:15
Closed_By roland-d
avatar roland-d roland-d - close - 25 Jun 2016
avatar roland-d roland-d - merge - 25 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - close - 25 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment