Feeling Lucky
?
[#10639] - [html5] Protostar frontend template
- Fixed in Code Base
- 28 May 2016
- Medium
- Build: staging
- # 10639
- Diff
- andrepereiradasilva:html5-protostar
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
Duplicate of
# 9842
User tests: Successful: Unsuccessful:
Summary of Changes
This is a redo of #9842 for protostar only.
This PR does a basic conversion of protostar template to HTML5.
Also made some minor corrections:
- Use scriptVersion for template js in all files
- Use the API in inline css/js (except error page)
- Use ie9 or lower hml5.js in all files.
Testing Instructions
- Install patch
- Set the site template as "Protostar" (if not yet)
- Go to frontend and check if the the following pages are working properly:
- normal page (test any existent URL)
- component popup (add
?tmpl=component&print=1to an existent page) - error pages (test one non existent URL)
- offline (set the site to offline and check the login page)
Check also the code changes.
Observations
All pages should now start with this code:
<!DOCTYPE html>
<html lang="en-gb" dir="ltr">
<head>
[...]
<meta charset="utf-8" />
[...]| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Templates (site) |
alikon
- comment
- 28 May 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10639.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 28 May 2016
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Rel_Number | 0 | ⇒ | 9842 |
| Relation Type | ⇒ | Duplicate of | |
| Labels | |||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-28 21:17:17 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 28 May 2016
Thanks everybody
I have tested this item✅ successfully on a498e6b
... at last. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10639.