[#10638] - [html5] System administrator template
- Closed
- 3 Sep 2016
- Medium
- Build: staging
- # 10638
- Diff
- andrepereiradasilva:html5-system-admin
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is a redo of #9842 for system admin only.
This PR does a basic conversion of system admin template to HTML5.
Also made some minor corrections:
- Use scriptVersion for template js in all files
- Use the API in inline css/js (except error page)
- Use ie9 or lower html5.js in all files.
Testing Instructions
- Install patch
- Add the following code to force the system template in the frontend (before https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/application/administrator.php#L185)
$this->template = new stdClass;
$this->template->template = 'system';
$this->template->params = new Registry;-
Go to admin and check if the the following pages are working properly (they don't have style):
- normal/component (test any existent page)
- error pages (test one non existent URL)
Remove the code added in 2. and check all is again ok and with style.
Check also the code changes.
Observations
All pages should now start with this code:
<!DOCTYPE html>
<html lang="en-gb" dir="ltr">
<head>
[...]
<meta charset="utf-8" />
[...]| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Templates (admin) |
I have applied this PR and added above code in given path file and line number.
Here is the screen-shots of my site before PR apply and after PR and above code applied.
First screen-shot is before PR apply.
Second screen-shot is after PR applied and code added.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10638.
Again, intended result. To properly test this, you HAVE to first apply the code hack to force the system template, then make a request so the system template displays pre-patch, then apply the patch and make another request. You can't compare pre-patch with a 100% unpatched install against post-patch with a code hack in place. Otherwise based on the steps you're presumably taking there is no way to ever test this patch successfully because it will appear as though the styling has gone AWOL.
@RonakParmar the code in the test instructions is exactly to force the system template (you can't select the system template in templates so we need to do this).
so for me it seems your test (first print screen) is a success.
I have tested this item
Without adding the given code to given file path PR works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10638.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10638.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
roland-d
- | Milestone |
Added: |
||
Can you rebase this please?
| Labels |
Added:
?
|
||
| Category | Templates (admin) | ⇒ | Templates (admin) Administration Installation Language & Strings |
Line endings?
Good job!
ok it's that thanks, strange this file must have an issue added to revert line endings to unix format in this particular file.
Is ok now
hint: use https://github.com/joomla/joomla-cms/pull/10638/files?w=1 if you want to check code diff after conflicts fix without whitespace changes
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 12:07:15 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item? unsuccessfully on bebe3dc
After adding below code before JPATH_ROOT . /libraries/cms/application/administrator.php line number 185 my site is not working.
$this->template = new stdClass;
$this->template->template = 'system';
$this->template->params = new Registry;
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10638.