? Success
Duplicate of # 9842

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
26 May 2016

Summary of Changes

This is a redo of #9842 for isis only.

This PR does a basic conversion of isis template to HTML5.
Also made some minor corrections:

  • Use script/style version for template js/css
  • Use the API in inline JS/CSS (except in error pages)
  • Use html5.js for browser lower than IE9 in all files.

Testing Instructions

  1. Install patch
  2. Set the admin template as "Isis" (if not yet)
  3. Go to admin and check if the the following pages are working properly:
    • normal page (test any existent URL)
    • component popup (add &tmpl=component&print=1 to an existent page)
    • error pages (test one non existent URL)
    • login (logoff and check the login page)

Check also the code changes.

Observations

All pages should now start with this code:

<!DOCTYPE html>
<html lang="en-gb" dir="ltr">
<head>
[...]
    <meta charset="utf-8" />
[...]
avatar andrepereiradasilva andrepereiradasilva - open - 26 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 26 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 26 May 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 26 May 2016
The description was changed
avatar brianteeman brianteeman - change - 26 May 2016
Category Templates (admin)
avatar ghazal ghazal - test_item - 28 May 2016 - Tested successfully
avatar ghazal
ghazal - comment - 28 May 2016

I have tested this item successfully on 0c29a4e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10637.

avatar alikon alikon - test_item - 28 May 2016 - Tested successfully
avatar alikon
alikon - comment - 28 May 2016

I have tested this item successfully on 0c29a4e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10637.

avatar brianteeman brianteeman - change - 28 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 28 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10637.

avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 28 May 2016
Milestone Added:
avatar roland-d roland-d - change - 28 May 2016
Rel_Number 0 9842
Relation Type Duplicate of
Labels
avatar roland-d roland-d - close - 28 May 2016
avatar roland-d roland-d - merge - 28 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 28 May 2016
avatar roland-d roland-d - reference | 14ed9ad - 28 May 16
avatar roland-d roland-d - merge - 28 May 2016
avatar roland-d roland-d - close - 28 May 2016
avatar roland-d roland-d - change - 28 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-28 21:08:22
Closed_By roland-d
Labels
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 28 May 2016

Thanks everybody

Add a Comment

Login with GitHub to post a comment