[#10642] - [JDocument render] Use real tabs for rendering tabs, not two spaces ...
- Fixed in Code Base
- 15 Jun 2016
- Medium
- Build: staging
- # 10642
- Diff
- andrepereiradasilva:patch-7
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Simple PR to use tabs for tabs instead of two spaces when rendering.
Note: don't know why the two spaces were there in the first place (since 6 Aug 2006)
Testing Instructions
Code review, or:
1. Go to any page and check the page source, check, for instance, the <script... starts after two spaces.
2. Apply patch
3. Repeat step 1 and check, for instance, the <script... starts after one tab.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
This PR has received new commits.
CC: @alikon
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642.
This PR has received new commits.
CC: @alikon
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642.
i was starting search for PHP_TAB , aborting now ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642.
ehheh yeah it was in bump.php (https://github.com/joomla/joomla-cms/blob/staging/build/bump.php#L36) i forgot that i defined as a constant there :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-15 23:27:51 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 059e3dd
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642.