I have tested this item successfully on 2e2af7c

Tested successfully on categories for articles, contacts and newsfeeds. Works as described. Great!

Works OK for all categories.
The edit button is broken for contact and newsfeed individual items: it just does not load the modal anymore here.

@infograf768 did you test on latest staging ?
As it is a fix for already merged changes, and contact and newsfeed were merged only yesterday (just before this issue report).

Sure, on latest staging

The error here comes from these changes:

-               . ' href="#contactEdit' . $this->id . 'Modal"'
+               . ' href="#contactEdit' . $this->value . 'Modal"'

and

        $html[] = JHtml::_(
            'bootstrap.renderModal',
-           'categoryEdit' . $this->id . 'Modal',
+           'categoryEdit' . $this->value . 'Modal',

After changing back to $this->id the modals load OK with an href of the type
#contactEditjform_associations_en_GBModal

hum, i had the exact same problem @infograf768 (and used the latest staging).

@JoomliC also, i notice a small detail not related to this PR.
Just letting you know in case you didn't notice.
When i change the category name from "Photo Gallery" to "Photo Gallery test" the category gets updated, ok. But, the category title in the zone where we have the "Select" "Edit" "Clear" doesn't get updated.

@JoomliC the "Edit" modals work on menu items, but not in associations.

Ok i see!
I will update this PR in a few hours (have to go) but the reason is alias passed to the value, so adding (int) before $this->value will solve it.
I will do extra checking when back, to be sure ;-)

This PR has received new commits.

CC: @BurtNL

@andrepereiradasilva @BurtNL @infograf768 PR updated and should work now with associations as well as in menus ;-)

@JoomliC also, i notice a small detail not related to this PR.
Just letting you know in case you didn't notice.
When i change the category name from "Photo Gallery" to "Photo Gallery test" the category gets updated, ok. But, the category title in the zone where we have the "Select" "Edit" "Clear" doesn't get updated.
image

@andrepereiradasilva Added too a new function for edit modal, to update the input title when changed ;-)
So to be tested too!

I have tested this item successfully on 2214bdc

Done tests in:

• "Select" and "Edit" buttons in Single Contact and Single News feed menu item types.
• "Select", "Edit" and "Clear" buttons in newsfeed, contact and category associations.

All worked without issues!

I have tested this item successfully on 2214bdc

Works great now.

RTc. Thanks! Let's go on for the other modals.

@JoomliC,

So after this PR gets merged, reggarding modals, that i see there is, the main remaining modals (for 3.6.0?):

• The latest changes also in Articles Edit/List modals
• The latest changes also in Modules Edit/List modals
• The same changes in Users List modal (if possible the "- No User -" option be in the modal buttons zone)

And the other less relevant modals (for 3.6.x or 3.7.0?):

• Use the new viewport height/width in the finder index modal, messages my settings, the multilanguage status module modal, the user notes list modal, redirect bulk import modal, the batch modals and other similiar modals (if other exist).

And some ideas:

• Converting the"Help" button popup up in a modal?
• Dynamic viewport height/width in the TinyMCE "+Article" "+Module" buttons?

Is this right? Or do i miss something?

@andrepereiradasilva You're right + a few minor improvement for com_template modals ;-)
First i will do priority update : article and module update (because of issues to fix)
Others will be much more cosmetic, consticency, and BS HTML structure standards

About Help, yes, good idea (for when i will have done others ;-) ) !
About TinyMCE, i don't know yet, as it's currently using TinyMCE modals (not Boostrap) which are not responsive. (not check yet, but think it could be possible to use BS modal instead of TinyMCE ones, as those 4 buttons are loaded by plugins.

This PR has received new commits.

CC: @andrepereiradasilva, @BurtNL, @infograf768

@andrepereiradasilva @rdeutz @infograf768 @BurtNL I have updated the PR, by simplifying the active id $value control (as well commented by @rdeutz ???? ) :

• Remove if / else
• Set empty only if active id is > 0 (do not allow negative id)
• Use $value in title query request instead of (int) $this->value > 0 as now, with my changes in this PR, the $value variable is set before.

Could review/test again ?
Thanks!

I have tested this item successfully on 29a6bf9

works fine

Even if this PR to fix newsfeeds, categories and contacts Select & Edit modals is not merged, i have created the PR for Article Select and Edit Modals with same fixes and updates applied here ;-)
#10557

I have tested this item ✅ successfully on 29a6bf9

I have tested this item ???? unsuccessfully on 29a6bf9

@JoomliC I am marking this as not tested successfully because I am not sure if this is part of this PR or a separate issue but this catches your attention :)

When I go to Newsfeed (or Articles) and edit an item go to the Images tab, click on the Select for the first image. This brings up the image modal. Clicking the X in the corner works fine but the Cancel button doesn't do anything. I would expect the modal to close here.

Removing RTC for now as there is an unsuccessful test.

@roland-d
I think you found another bug (which I confirm) unrelated to the purpose of this PR.

@roland-d I will check it in another PR, as not related to this PR. But well found! ????
And... the issue is already there in stable 3.5.1 !
So, will check this today ;-)

But you can set RTC again here ;-)

@JoomliC Thank you for checking, will move this forward.

Thanks everybody

@roland-d : PR done to fix "Cancel" button in image modal : #10564
;-)