Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10521] - [js message system] Correct js messages class

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
16 May 2016

Summary of Changes

Simple PR to correct the colors and titles of the js messages.

Before

image

After

image

Testing Instructions

  • Go to isis/protostar index.php and add this code
// JS Messages
JText::script('MESSAGE');
JText::script('ERROR');
JText::script('NOTICE');
JText::script('WARNING');

JFactory::getDocument()->addScriptDeclaration("
jQuery(document).ready(function() {
    var messages = {
        'message': ['JS Success Message 1', 'JS Success Message 2'],
        'error': ['JS Error Message 1', 'JS Error Message 2'],
        'notice': ['JS Notice Message 1', 'JS Notice Message 2'],
        'warning': ['JS Warning Message 1', 'JS Warning Message 2']
    };
    Joomla.renderMessages(messages);
});");
  • Now run any isis/protostar page. You'll see the "Before" scenario
  • Apply patch
  • Repeat step 2 (clear browser cache). You will see the "After" scenario.
avatar andrepereiradasilva andrepereiradasilva - open - 16 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 16 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 17 May 2016
Category ⇒ JavaScript
avatar brianteeman brianteeman - test_item - 17 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 May 2016

I have tested this item :white_check_mark: successfully on 8575693

Good spot

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10521.

avatar infograf768 infograf768 - test_item - 17 May 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 17 May 2016

I have tested this item :white_check_mark: successfully on 8575693

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10521.

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 May 2016

thanks for testing @brianteeman @infograf768 !

avatar brianteeman brianteeman - change - 17 May 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 17 May 2016

Rtc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10521.

avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 17 May 2016
Milestone Added:
avatar Kubik-Rubik
Kubik-Rubik - comment - 17 May 2016

Thank you @andrepereiradasilva and testers!

avatar Kubik-Rubik Kubik-Rubik - close - 17 May 2016
avatar Kubik-Rubik Kubik-Rubik - merge - 17 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 17 May 2016
avatar Kubik-Rubik Kubik-Rubik - reference | 4052683 - 17 May 16
avatar Kubik-Rubik Kubik-Rubik - merge - 17 May 2016
avatar Kubik-Rubik Kubik-Rubik - change - 17 May 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-17 11:11:26
Closed_By ⇒ Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 17 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 17 May 2016

Add a Comment

Login with GitHub to post a comment