[#10523] - [imp] New lang string for successful language installation
- Fixed in Code Base
- 17 May 2016
- Medium
- Build: staging
- # 10523
- Diff
- infograf768:lang_string_install_language
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The language string for language installation is the same as used in general install.
COM_INSTALLER_INSTALL_SUCCESS="Installation of the %s was successful."
In the case of general install, the variable is of the type
COM_INSTALLER_TYPE_TYPE_COMPONENT="component"
COM_INSTALLER_TYPE_TYPE_FILE="file"
COM_INSTALLER_TYPE_TYPE_LANGUAGE="language"
COM_INSTALLER_TYPE_TYPE_LIBRARY="library"
COM_INSTALLER_TYPE_TYPE_MODULE="module"
COM_INSTALLER_TYPE_TYPE_PACKAGE="package"
COM_INSTALLER_TYPE_TYPE_PLUGIN="plugin"
COM_INSTALLER_TYPE_TYPE_TEMPLATE="template"
This does not fit with installing a language pack as we get
Ugly in any language...
This PR adds a new string for language installation:
COM_INSTALLER_INSTALL_LANGUAGE_SUCCESS="Installation of the <strong>%s</strong> language pack was successful."
Which gives:
To test go to administrator/index.php?option=com_installer&view=languages and install any language.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
I was wondering if we even need that word at all.
COM_INSTALLER_INSTALL_LANGUAGE_SUCCESS="Installation of the
%s language was successful."
On 17 May 2016 at 08:52, infograf768 notifications@github.com wrote:
@brianteeman https://github.com/brianteeman
I can change pack to package
COM_INSTALLER_INSTALL_LANGUAGE_SUCCESS="Installation of the
%s language package was successful."
if you wish.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10523 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Category | ⇒ | Installation Language & Strings |
| Labels | |||
No objection.
I think we can skip "pack" or "package" and just use "language"
Make it so and I will make it RTC- its a simple and obvious improvement
The text phrase "Installation of the %s language was successful." is fine.
Please mark test as successful IN https://issues.joomla.org/tracker/joomla-cms/10523
I have tested this item 
successfully on 940a822
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
We could make even simpler like: "%s language is now installed."
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.
I have tested this item successfully on 940a822
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.
I have tested this item successfully on 940a822
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10523.
Thank you @infograf768!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-17 15:51:07 |
| Closed_By | ⇒ | Kubik-Rubik |
@joomla-cms-bot come here and fix the label :P
| Labels |
Removed:
?
|
||
@brianteeman
I can change pack to package
COM_INSTALLER_INSTALL_LANGUAGE_SUCCESS="Installation of the <strong>%s</strong> language package was successful."if you wish.