[#10393] - [com_content] modal articles & article edit : add viewport dimensions
- Fixed in Code Base
- 11 May 2016
- Medium
- Build: staging
- # 10393
- Diff
- JoomliC:modal-article-edit-add-viewport-dimensions
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
To be tested on latest Staging (needs #10388 )
Summary of Changes
- Add viewport dimensions to modal Article Select and Edit (modal width: 80vw, modal body height: 70vh)
- Follow code style: Indent for array
Testing Instructions
This modal could be tested by creating a new menu item:
- Select type = single article
- First Modal using viewport units of this PR : select an article (Select button)
- Then save the menu to be able to view the edit button
- Second Modal using viewport units of this PR : edit article (Edit button)
- You can test too the 2 modals in Article Edition > Associations
Before Patch
After Patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Components UI/UX |
I have tested this item 
successfully on 353723c
thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10393.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-11 06:25:46 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
i think this has nothing to do with your PR but didn't you notice the js error on closing the edit article and edit module modals?
i notice that while testing the jquery version update PR #9935 (comment)
@andrepereiradasilva Thanks, didn't test with this PR concerning jQuery update, but on staging.
But the issue is not related to the changes made by this PR (viewport dimensions) nor the one with the change to edit article modal in menu, but by the script loaded by module edit, which i have adapted for article edit. (And as i have used the same, just changing module by article, it's normal now to have this issue in the article 2).
The issue was already there in this script.
So, i wlll check this as i'm working on other modals "item edit" not committed yet, and will then create a patch for edit article and module script (maybe needs a time delay...)
Not had finally enought time today, but will see this in the next days... ;-)
@andrepereiradasilva Just did the PR for typeError message ;-)
Module Modal : #10427
Module Article : #10428
I have tested this item
successfully on 353723c
Great work again!
The modals are becoming much better with all the latest changes!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10393.