Feeling Lucky
?
[#10394] - [com_menus] modal module edit: add viewport dimensions
- Fixed in Code Base
- 11 May 2016
- Medium
- Build: staging
- # 10394
- Diff
- JoomliC:modal-module-edit-add-viewport-dimensions
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
To be tested on latest Staging (needs #10388 )
Summary of Changes
- Add viewport dimensions to modal Module Edit (modal width: 80vw, modal body height: 70vh)
- Follow code style: Indent for array
- Remove dupplicated closeButton option (mine error in previous PR)
Testing Instructions
This modal could be tested in each menu item edition:
- Go to
Module Assignmenttab - Click on any module title to open the module edition
Before Patch
After Patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Components UI/UX |
MATsxm
- comment
- 10 May 2016
I have tested this item 
successfully on 1002d9a
Great - merci 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10394.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 10 May 2016
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-11 06:25:00 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 1002d9a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10394.