[#10392] - Fix background on loading joomlaupdate
- Fixed in Code Base
- 21 May 2016
- Medium
- Build: staging
- Easy Test
- # 10392
- Diff
- 810:language
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Issue
When you install the update package you see a spinner with a background, only
the height and weight are wrong
Test instructions
•Go to Components > Joomla Update, Select "Upload & Update" tab and send a big file (any file with 1MB, for instance, works). You'll notice the white layer with joomla logo it's cropped (not full height). Press Cancel on next screen.
or use developer tools to disable display:none; class
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | Updating |
| Category | Updating | ⇒ | UI/UX Updating |
I have tested this item 
successfully on 11c575b
Since the test instructions are missing this is what i did.
- Go to Components > Joomla Update, Select "Upload & Update" tab and send a big file (any file with 1MB, for instance, works). You'll notice the white layer with joomla logo it's cropped (not full height). Press Cancel on next screen.
- Apply this patch repeat the same process. Now ok.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10392.
@andrepereiradasilva updated
"When you install a component" ? this is joomla update :)
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10392.
I have tested this item successfully on 49bc345
First using the updater only the top part is blurred with the logo, after applying the patch, the full screen is blurred with the logo.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10392.
I really don't think we should be using jQuery to apply styling to the #loading element. It would be better to simply add a class, then use CSS for the styling
Please also test on mobile. The top position is too big
@andrepereiradasilva has started to do this way: #10396
Only we need a solution for spinning on IE/Edge
Is this ready for being merged or is there an update coming?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10392.
I have tested this item
As with the previous test this is what I did;
Went to Components > Joomla Update, Select "Upload & Update" tab and attached a big file. Took screenshot to prove issue
Applied patch & repeated the process & now all OK Again proved with screenshot as the spinner was showing up fast
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10392.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-21 16:31:27 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
Thanks everybody
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10392.
maybe this one can be merged by code review. Same as #10343