? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
10 May 2016

Pull Request for Improvement.

Summary of Changes

In CPanel modules (mod_logged, mod_latest and mod_popular):

  • Adds and uniformizes tooltip (indicating that is the created date) on dates.
  • Uniformizes the modules alignment.
  • Uniformizes the date format (added a new LC5 Y-m-d H:i date).
  • Right align the dates

Before
image

After
image

Testing Instructions

  1. Use joomla staging with test sample data
  2. Go to CPanel check the align and the date tooltips in the 3 modules
  3. Apply patch
  4. Go to CPanel check the align and the date tooltips in the 3 modules

@brianteeman please check now

avatar andrepereiradasilva andrepereiradasilva - open - 10 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 10 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 10 May 2016

I really dont see the need for this change

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

why? this is the homepage of the admin and IMO it's clearly disaligned.

Also what is that date (published? modified? created?)?
now the tooltip informs the user that is the Created date

Another example:

Before
image

After
image

avatar brianteeman
brianteeman - comment - 10 May 2016

this is the homepage of the admin

That depends on the sample data installed

On 10 May 2016 at 14:52, andrepereiradasilva notifications@github.com
wrote:

why? this is the homepage of the admin and IMO it's clearly disaligned.

Also what is that date (published? modified? created?)?
now the tooltip informs the user that is the Created date

Another example:

Before
[image: image]
https://cloud.githubusercontent.com/assets/9630530/15148780/b9cd0d7c-16be-11e6-90ec-18690f3e6822.png

After
[image: image]
https://cloud.githubusercontent.com/assets/9630530/15148764/ad1a4f54-16be-11e6-81c5-5409535776c9.png


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10385 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

yes i know. is just to exemplify.

avatar zero-24 zero-24 - change - 10 May 2016
Category UI/UX
avatar zero-24 zero-24 - change - 10 May 2016
Easy No Yes
avatar zero-24 zero-24 - change - 10 May 2016
Status Pending Needs Review
avatar zero-24
zero-24 - comment - 10 May 2016

Moving to Needs review so a maintainer can take a decision here. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10385.

avatar BurtNL BurtNL - test_item - 10 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 10 May 2016

I have tested this item :white_check_mark: successfully on 9850d82


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10385.

avatar MATsxm MATsxm - test_item - 10 May 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 10 May 2016

I have tested this item :white_check_mark: successfully on 9850d82

Don't know if users need this but #10385 works as descibed and I really do prefer the "new" logged-in users - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10385.

avatar sonalitasol sonalitasol - test_item - 24 Jun 2016 - Tested successfully
avatar sonalitasol
sonalitasol - comment - 24 Jun 2016

I have tested this item successfully on 9850d82


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10385.

avatar zero-24
zero-24 - comment - 24 Jun 2016

@wilsonge @rdeutz can you take a decision here?

avatar conconnl conconnl - test_item - 7 Jul 2016 - Tested successfully
avatar conconnl
conconnl - comment - 7 Jul 2016

I have tested this item successfully on 9850d82

Tested this.
I looks much better.
Please add this UX fix


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10385.

avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Jul 2016

Needs Review ...

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Sep 2016

can a mantainer please take a decision here? merge or close?

avatar wilsonge wilsonge - change - 5 Sep 2016
Status Needs Review Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-05 22:17:23
Closed_By wilsonge
avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Sep 2016

thanks

avatar wilsonge
wilsonge - comment - 5 Sep 2016

Thankyou!

Add a Comment

Login with GitHub to post a comment