Feeling Lucky
?
?
[#10384] - redis is valid for hhvm
- Fixed in Code Base
- 10 May 2016
- Medium
- Build: staging
- # 10384
- Diff
- photodude:patch-4
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for one of the failures in Issue #10220 .
Summary of Changes
removes redis exclusion from hhvm testing
fixes unit test failure
JCacheStorageTest::testGetInstance with data set "defaultredis" ('redis', array(null, 'en-GB', true, null, 1462454997), 'JCacheStorageRedis')
Undefined variable: connection
/tests/unit/core/helper/helper.php:52
/libraries/joomla/cache/storage/redis.php:105
/libraries/joomla/cache/storage/redis.php:48
/libraries/joomla/cache/storage.php:169
/tests/unit/suites/libraries/joomla/cache/JCacheStorageTest.php:238Testing Instructions
merge on review
Since hhvm is failing with memory I have a patch where I filtered for just the cache tests
before patch error (showing just redis cache test failures)
https://travis-ci.org/photodude/joomla-cms/jobs/127977188
after patch the redis error is gone (showing all cache tests, redis is no longer in the list)
https://travis-ci.org/photodude/joomla-cms/jobs/129048590
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
brianteeman
- | Labels | |||
| Category | ⇒ | Cache Unit Tests |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-10 13:32:37 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
| Milestone |
Added: |
||