? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
10 May 2016

Summary of Changes

Codestyle for the tinymce xml file

Testing Instructions

  • apply the patch
  • go to the tinymce options
  • confirm that all still there
  • or code review
avatar zero-24 zero-24 - open - 10 May 2016
avatar zero-24 zero-24 - change - 10 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

The four attributes name, type, label and description should be written in this order and at the top of the element definition.

See http://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md

avatar zero-24
zero-24 - comment - 10 May 2016

here you go: abad727 we should get rid of all that option :P

avatar zero-24 zero-24 - change - 10 May 2016
Easy No Yes
avatar andrepereiradasilva andrepereiradasilva - test_item - 10 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

I have tested this item :white_check_mark: successfully on abad727


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10386.

avatar zero-24 zero-24 - change - 10 May 2016
Category Code style
avatar MATsxm MATsxm - test_item - 10 May 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 10 May 2016

I have tested this item :white_check_mark: successfully on abad727

everything looks :+1: - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10386.

avatar brianteeman brianteeman - change - 10 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 10 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10386.

avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 10 May 2016
Milestone Added:
avatar rdeutz rdeutz - close - 10 May 2016
avatar rdeutz rdeutz - change - 10 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-10 18:14:33
Closed_By rdeutz
avatar rdeutz rdeutz - close - 10 May 2016
avatar rdeutz rdeutz - merge - 10 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 10 May 2016
avatar rdeutz rdeutz - reference | e8fb72d - 10 May 16
avatar rdeutz rdeutz - merge - 10 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Removed: ?
avatar zero-24
zero-24 - comment - 10 May 2016

Thanks

avatar zero-24 zero-24 - head_ref_deleted - 10 May 2016

Add a Comment

Login with GitHub to post a comment