? Success
Pull Request for # 10032

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
8 May 2016

Pull Request for Issue #10032

Summary of Changes

Overrides the PHPMailer::isSendmail() method to remove the restriction on the name of the sendmail binary's name and to read the sendmail path configured in the global configuration (defaulting to PHP's sendmail_path if something isn't set in the global config and ultimately defaulting to /usr/sbin/sendmail if neither of those give a path).

Testing Instructions

Set a custom sendmail path in the global config, send a message using it, and ensure PHPMailer uses the correct binary path.

avatar mbabker mbabker - open - 8 May 2016
avatar mbabker mbabker - change - 8 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 8 May 2016
Rel_Number 0 10032
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 8 May 2016
Category Libraries
avatar andrepereiradasilva
andrepereiradasilva - comment - 9 May 2016

tested with sucess!

Used /sbin/sendmail as sendmail binary path.

And used "Send Test mail" button with the Mailer set to "Sendmail"

Before patch
image

After patch
image

The "error" is because the usage of escapeshellarg is not allowed on the server.
But for this test is enough.

avatar andrepereiradasilva andrepereiradasilva - test_item - 9 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 9 May 2016

I have tested this item :white_check_mark: successfully on 669eb90


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10342.

avatar zero-24 zero-24 - test_item - 10 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 10 May 2016

I have tested this item :white_check_mark: successfully on 669eb90

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10342.

avatar zero-24 zero-24 - change - 10 May 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 10 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10342.

avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 10 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 10 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-10 15:58:04
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 May 2016
avatar wilsonge wilsonge - merge - 10 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 10 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment